Re: [PATCH ha-manager v3 10/21] api: resources: migration: support additional migration options

[Fiona Ebner <f.ebner@proxmox.com>]

Am 14.10.26 um 9:59 AM schrieb Daniel Kral:
> On Tue Oct 13, 2026 at 4:34 PM CEST, Fiona Ebner wrote:
>> Am 12.10.26 um 11:59 AM schrieb Daniel Kral:
>>> On Fri Sep 18, 2026 at 6:08 PM CEST, Fiona Ebner wrote:
>>>> +    my $version_info = PVE::Cluster::get_node_kv('version-info');
>>>> +    for my $node (sort keys $version_info->%*) {
>>>> +        my $node_info = eval { JSON::decode_json($version_info->{$node}); };
>>>> +        if (my $err = $@) { # warn, but continue
>>>> +            syslog('warn', "cannot parse version info for $node as JSON - $err");
>>>
>>> Shouldn't we fail if it's not possible to determine a node's version?
>>
>> No, this is deliberate. Updated cluster is the usual situation. An error
>> here should not affect the usual situation. I'm choosing to affect the
>> unusual situation, where the master happens to be too old and unable to
>> report its version properly, which should be rare. The failure is also
>> not critical: it will be an ignored CRM command with warnings/errors
>> logged until the version can be determined again.
> 
> Yeah, since 'version-info' is broadcasted in the same format since
> Proxmox VE 7.1 so that shouldn't be a problem.
> 
>>
>> But I will switch the order below and keep submitting a non-JSON CRM
>> command if the new style is not actually required. This gives an escape
>> hatch.
> 
> This depends if we want to switch to only the JSON CRM command format in
> the future, then it would be preferable to always use the new format so
> we can switch to it in some future major version, at least for the
> migrate command?

I don't see the hurry with phasing out the non-JSON variant. We can keep
the handling for it for backwards-compat until we have a good reason to
drop it. I'd be in favor of reducing potential for issues now, even if
it's just in the edge case with old master node+failing version check.
But I'll add a reminder to switch to submitting the JSON variant for the
next major version, so we can do the first step then.