Re: [PATCH ha-manager v3 07/21] next state: handle motion command: support migration options

["Daniel Kral" <d.kral@proxmox.com>]

On Fri Sep 18, 2026 at 6:08 PM CEST, Fiona Ebner wrote:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> New in v3.
>
>  src/PVE/HA/Manager.pm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
> index d61e50c..1d9ff36 100644
> --- a/src/PVE/HA/Manager.pm
> +++ b/src/PVE/HA/Manager.pm
> @@ -1301,6 +1301,7 @@ my sub next_state_handle_motion_command {
>      my $ns = $self->{ns};
>  
>      my $target = shift @{ $sd->{cmd} };
> +    my $migrate_options = shift @{ $sd->{cmd} };

I'd prefer the postfix $sd->{cmd}->@* here

>      if (!$ns->node_is_online($target)) {
>          $haenv->log('err', "ignore service '$sid' $cmd request - node '$target' not online");
>      } elsif ($sd->{node} eq $target) {
> @@ -1310,7 +1311,16 @@ my sub next_state_handle_motion_command {
>          );
>      } else {
>          $haenv->log('info', "$cmd service '$sid' to node '$target'");
> -        &$change_service_state($self, $sid, $cmd, node => $sd->{node}, target => $target);
> +
> +        my $params = {
> +            node => $sd->{node},
> +            target => $target,
> +        };
> +        if ($migrate_options && scalar(keys $migrate_options->%*) > 0) {
> +            $params->{'migrate-options'} = $migrate_options;
> +        }
> +
> +        $change_service_state->($self, $sid, $cmd, $params->%*);

Here it does change to the postfix syntax then :-)

>          return 1;
>      }
>  

Otherwise:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>