public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager v4 6/7] ui: sdn: add BGP fabric support
Date: Wed, 13 May 2026 14:38:15 +0200	[thread overview]
Message-ID: <2e6a612c-6350-4bf8-86fb-7b33378c1e0d@proxmox.com> (raw)
In-Reply-To: <20260512141305.199664-7-h.laimer@proxmox.com>

On 5/12/26 4:12 PM, Hannes Laimer wrote:

[snip]

> diff --git a/www/manager6/sdn/fabrics/bgp/FabricEdit.js b/www/manager6/sdn/fabrics/bgp/FabricEdit.js
> new file mode 100644
> index 00000000..c4a94a52
> --- /dev/null
> +++ b/www/manager6/sdn/fabrics/bgp/FabricEdit.js
> @@ -0,0 +1,67 @@
> +Ext.define('PVE.sdn.Fabric.Bgp.Fabric.Edit', {
> +    extend: 'PVE.sdn.Fabric.Fabric.Edit',
> +
> +    subject: 'BGP',
> +    onlineHelp: 'pvesdn_bgp_fabric',
> +
> +    extraRequestParams: {
> +        protocol: 'bgp',
> +    },
> +
> +    additionalItems: [
> +        {
> +            xtype: 'proxmoxcheckbox',
> +            fieldLabel: gettext('BFD'),
> +            labelWidth: 120,
> +            name: 'bfd',
> +            uncheckedValue: 0,
> +            defaultValue: 0,
> +        },
> +        {
> +            xtype: 'pveSDNPrefixListSelector',
> +            name: 'route_filter',
> +            fieldLabel: gettext('Route Filter'),
> +            emptyText: gettext('IP Prefixes'),
> +            deleteEmpty: true,
> +            skipEmptyText: true,
> +        },
> +    ],
> +
> +    additionalAdvancedItems: [
> +        {
> +            xtype: 'pveSDNRouteMapSelector',
> +            name: 'route_map_in',
> +            fieldLabel: gettext('Incoming Route Map'),
> +            emptyText: gettext('Route Map'),
> +            deleteEmpty: true,
> +            skipEmptyText: true,
> +        },
> +        {
> +            xtype: 'pveSDNRouteMapSelector',
> +            name: 'route_map_out',
> +            fieldLabel: gettext('Outgoing Route Map'),
> +            emptyText: gettext('Route Map'),
> +            deleteEmpty: true,
> +            skipEmptyText: true,
> +        },
> +    ],

setting labelWidth: 120 to the routemap / routefilter elements would
make the width of all input fields uniform.




  reply	other threads:[~2026-05-13 12:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 14:12 [PATCH docs/manager/network/proxmox{-ve-rs,-perl-rs} v4 0/7] sdn: add BGP fabric Hannes Laimer
2026-05-12 14:12 ` [PATCH proxmox-ve-rs v4 1/7] sdn: fabric: add BGP protocol support Hannes Laimer
2026-05-13 12:29   ` Stefan Hanreich
2026-05-13 13:00     ` Hannes Laimer
2026-05-12 14:13 ` [PATCH proxmox-perl-rs v4 2/7] sdn: fabrics: add BGP config generation Hannes Laimer
2026-05-12 14:13 ` [PATCH proxmox-perl-rs v4 3/7] sdn: fabrics: add BGP status endpoints Hannes Laimer
2026-05-13 12:33   ` Stefan Hanreich
2026-05-13 13:02     ` Hannes Laimer
2026-05-12 14:13 ` [PATCH pve-network v4 4/7] sdn: fabrics: register bgp as a fabric protocol type Hannes Laimer
2026-05-12 14:13 ` [PATCH pve-network v4 5/7] test: evpn: add integration test for EVPN over BGP fabric Hannes Laimer
2026-05-12 14:13 ` [PATCH pve-manager v4 6/7] ui: sdn: add BGP fabric support Hannes Laimer
2026-05-13 12:38   ` Stefan Hanreich [this message]
2026-05-12 14:13 ` [PATCH pve-docs v4 7/7] sdn: add bgp fabric section Hannes Laimer
2026-05-13 12:39 ` [PATCH docs/manager/network/proxmox{-ve-rs,-perl-rs} v4 0/7] sdn: add BGP fabric Stefan Hanreich
2026-05-13 18:43 ` superseded: " Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e6a612c-6350-4bf8-86fb-7b33378c1e0d@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal