Re: [PATCH proxmox-perl-rs v4 3/7] sdn: fabrics: add BGP status endpoints

[Hannes Laimer <h.laimer@proxmox.com>]

On 2026-05-13 14:33, Stefan Hanreich wrote:
> On 5/12/26 4:12 PM, Hannes Laimer wrote:
>> Expose BGP fabric status through the existing fabric status API.
>> Routes are fetched for both IPv4 and IPv6, and neighbor/interface
>> state is derived from BGP session info.
>>
>> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
>> ---
>>  pve-rs/src/bindings/sdn/fabrics.rs |  97 +++++++++++++++++++++++++-
>>  pve-rs/src/sdn/status.rs           | 106 ++++++++++++++++++++++++++++-
>>  2 files changed, 198 insertions(+), 5 deletions(-)
>>
>> diff --git a/pve-rs/src/bindings/sdn/fabrics.rs b/pve-rs/src/bindings/sdn/fabrics.rs
>> index f914094..0189ecd 100644
>> --- a/pve-rs/src/bindings/sdn/fabrics.rs
>> +++ b/pve-rs/src/bindings/sdn/fabrics.rs
>> @@ -12,8 +12,8 @@ pub mod pve_rs_sdn_fabrics {
>>      use std::process::Command;
>>      use std::sync::Mutex;
>>  
>> -    use anyhow::{Context, Error, format_err};
>> -    use openssl::hash::{MessageDigest, hash};
>> +    use anyhow::{format_err, Context, Error};
>> +    use openssl::hash::{hash, MessageDigest};
>>      use proxmox_ve_config::sdn::fabric::section_config::node::api::{Node, NodeUpdater};
>>      use serde::{Deserialize, Serialize};
>>  
>> @@ -31,8 +31,8 @@ pub mod pve_rs_sdn_fabrics {
>>      };
>>      use proxmox_ve_config::sdn::fabric::section_config::interface::InterfaceName;
>>      use proxmox_ve_config::sdn::fabric::section_config::node::{Node as ConfigNode, NodeId};
>> -    use proxmox_ve_config::sdn::fabric::section_config::Section;
>>      use proxmox_ve_config::sdn::fabric::section_config::protocol::bgp::BgpNode;
>> +    use proxmox_ve_config::sdn::fabric::section_config::Section;
>>      use proxmox_ve_config::sdn::fabric::{FabricConfig, FabricEntry};
>>      use proxmox_ve_config::sdn::wireguard::WireGuardConfigBuilder;
>>  
>> @@ -840,6 +840,35 @@ pub mod pve_rs_sdn_fabrics {
>>                  status::get_routes(fabric_id, config, ospf_routes, proxmox_sys::nodename())
>>              }
>>              FabricEntry::WireGuard(_) => Ok(Vec::new()),
>> +            FabricEntry::Bgp(_) => {
>> +                let bgp_ipv4_routes_string = String::from_utf8(
>> +                    Command::new("sh")
>> +                        .args(["-c", "vtysh -c 'show ip route bgp json'"])
>> +                        .output()?
>> +                        .stdout,
>> +                )?;
>> +
>> +                let bgp_ipv6_routes_string = String::from_utf8(
>> +                    Command::new("sh")
>> +                        .args(["-c", "vtysh -c 'show ipv6 route bgp json'"])
>> +                        .output()?
>> +                        .stdout,
>> +                )?;
> 
> pre-existing but something that really irks me is that we pollute the
> vtysh history with our pvestatd invocations. It's possible to set
> VTYSH_HISTFILE=/dev/null to avoid writing the commands to history - so
> we could do that here for all vtysh invocations?
> 

could also do as a follow-up that does this for all, but can also
include in v5 for bgp fabric. fine with me either way

> I can prepare a patch for OSPF / Openfabric.
>