From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 2EE091FF13A
	for <inbox@lore.proxmox.com>; Wed, 13 May 2026 14:38:51 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id E3D0EC5BF;
	Wed, 13 May 2026 14:38:49 +0200 (CEST)
Message-ID: <2e6a612c-6350-4bf8-86fb-7b33378c1e0d@proxmox.com>
Date: Wed, 13 May 2026 14:38:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH pve-manager v4 6/7] ui: sdn: add BGP fabric support
To: pve-devel@lists.proxmox.com
References: <20260512141305.199664-1-h.laimer@proxmox.com>
 <20260512141305.199664-7-h.laimer@proxmox.com>
Content-Language: en-US
From: Stefan Hanreich <s.hanreich@proxmox.com>
In-Reply-To: <20260512141305.199664-7-h.laimer@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.611 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: DOYD3EZL6F6FAII6JOQZHCLODH4ZEI4B
X-Message-ID-Hash: DOYD3EZL6F6FAII6JOQZHCLODH4ZEI4B
X-MailFrom: s.hanreich@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On 5/12/26 4:12 PM, Hannes Laimer wrote:

[snip]

> diff --git a/www/manager6/sdn/fabrics/bgp/FabricEdit.js b/www/manager6/sdn/fabrics/bgp/FabricEdit.js
> new file mode 100644
> index 00000000..c4a94a52
> --- /dev/null
> +++ b/www/manager6/sdn/fabrics/bgp/FabricEdit.js
> @@ -0,0 +1,67 @@
> +Ext.define('PVE.sdn.Fabric.Bgp.Fabric.Edit', {
> +    extend: 'PVE.sdn.Fabric.Fabric.Edit',
> +
> +    subject: 'BGP',
> +    onlineHelp: 'pvesdn_bgp_fabric',
> +
> +    extraRequestParams: {
> +        protocol: 'bgp',
> +    },
> +
> +    additionalItems: [
> +        {
> +            xtype: 'proxmoxcheckbox',
> +            fieldLabel: gettext('BFD'),
> +            labelWidth: 120,
> +            name: 'bfd',
> +            uncheckedValue: 0,
> +            defaultValue: 0,
> +        },
> +        {
> +            xtype: 'pveSDNPrefixListSelector',
> +            name: 'route_filter',
> +            fieldLabel: gettext('Route Filter'),
> +            emptyText: gettext('IP Prefixes'),
> +            deleteEmpty: true,
> +            skipEmptyText: true,
> +        },
> +    ],
> +
> +    additionalAdvancedItems: [
> +        {
> +            xtype: 'pveSDNRouteMapSelector',
> +            name: 'route_map_in',
> +            fieldLabel: gettext('Incoming Route Map'),
> +            emptyText: gettext('Route Map'),
> +            deleteEmpty: true,
> +            skipEmptyText: true,
> +        },
> +        {
> +            xtype: 'pveSDNRouteMapSelector',
> +            name: 'route_map_out',
> +            fieldLabel: gettext('Outgoing Route Map'),
> +            emptyText: gettext('Route Map'),
> +            deleteEmpty: true,
> +            skipEmptyText: true,
> +        },
> +    ],

setting labelWidth: 120 to the routemap / routefilter elements would
make the width of all input fields uniform.