public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH cluster v2 0/1] datacenter config: add ticket-signature-hash option
@ 2026-11-13  3:06 Mark Atwood
  2026-11-13  3:06 ` [PATCH cluster v2 1/1] " Mark Atwood
  0 siblings, 1 reply; 7+ messages in thread
From: Mark Atwood @ 2026-11-13  3:06 UTC (permalink / raw)
  To: pve-devel

Add a cluster-wide datacenter.cfg option 'ticket-signature-hash' (sha1 or
sha256, default sha1) for the hash of the RSA signature of newly created
authentication tickets. pve-access-control reads it, see that patch. It
exists so that setups where SHA-1 signatures are not acceptable, e.g. FIPS
mode, can enable SHA-256 signed tickets now. Nothing changes by default.

This is the pve-cluster part of the v2 of "ticket: sign RSA tickets with
SHA-256". The pve-common part also affects Proxmox Mail Gateway, which
uses PVE::Ticket; this option does not affect PMG.

Apply order across the repositories, all three are part of this series:
1. pve-common (2 patches)
2. pve-cluster (adds the datacenter.cfg option)
3. pve-access-control (reads the option and signs with it)
pve-common and pve-cluster are independent of each other. pve-access-control
needs both, but is harmless without them: it then keeps signing with SHA-1.

Mixed clusters: nodes without pve-common 1/2 reject SHA-256 tickets, so the
option must only be set to 'sha256' once every node has that patch. The option
description says so. I did not add an automatic check against the node
versions (the new helpers in pve-cluster, 679cf2c, would allow one), as it
needs the release number that will contain 1/2. Happy to add one in
pve-manager's datacenter options update once that number is known.

Changes since v1: the option is new in v2. v1 switched signing to SHA-256
unconditionally, with an environment variable for the transition. Shannon
asked for opt-in, so FIPS users can enable it now, and a cluster-wide
datacenter.cfg option with default off was chosen. It is a plain enum, as the
hyphenated names of the newer options ('next-id', 'tag-style') suggest, and
leaves room for more hashes. The other v1 review points are in the pve-common
cover letter.

v1: <CALkZksWBSdQa5AsvhmANGAJigcZ7FHPtgRgdu3JsRt9NX6vwSg@mail.gmail.com>
This is sent as a new thread, as is usual for a new version of a series.

Thanks to Shannon Sterz for the review of v1.

Mark Atwood (1):
  datacenter config: add ticket-signature-hash option

 src/PVE/DataCenterConfig.pm            | 16 +++++++++++
 src/test/Makefile                      |  6 ++++-
 src/test/test_ticket_signature_hash.pl | 37 ++++++++++++++++++++++++++
 3 files changed, 58 insertions(+), 1 deletion(-)
 create mode 100644 src/test/test_ticket_signature_hash.pl


base-commit: 679cf2c674254f41ddd89cc8e4e17d83c8444ad7



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-19 13:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-13  3:06 [PATCH cluster v2 0/1] datacenter config: add ticket-signature-hash option Mark Atwood
2026-11-13  3:06 ` [PATCH cluster v2 1/1] " Mark Atwood
2026-11-17 16:05   ` Shannon Sterz
2026-11-18  4:14   ` Thomas Lamprecht
2026-11-18  9:40     ` Shannon Sterz
2026-11-19 12:38       ` Thomas Lamprecht
2026-11-19 13:37         ` Shannon Sterz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal