From: Mark Atwood <mark@wolfssl.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH cluster v2 0/1] datacenter config: add ticket-signature-hash option
Date: Fri, 13 Nov 2026 03:06:45 +0000 [thread overview]
Message-ID: <20261113030646.3533-1-mark@wolfssl.com> (raw)
Add a cluster-wide datacenter.cfg option 'ticket-signature-hash' (sha1 or
sha256, default sha1) for the hash of the RSA signature of newly created
authentication tickets. pve-access-control reads it, see that patch. It
exists so that setups where SHA-1 signatures are not acceptable, e.g. FIPS
mode, can enable SHA-256 signed tickets now. Nothing changes by default.
This is the pve-cluster part of the v2 of "ticket: sign RSA tickets with
SHA-256". The pve-common part also affects Proxmox Mail Gateway, which
uses PVE::Ticket; this option does not affect PMG.
Apply order across the repositories, all three are part of this series:
1. pve-common (2 patches)
2. pve-cluster (adds the datacenter.cfg option)
3. pve-access-control (reads the option and signs with it)
pve-common and pve-cluster are independent of each other. pve-access-control
needs both, but is harmless without them: it then keeps signing with SHA-1.
Mixed clusters: nodes without pve-common 1/2 reject SHA-256 tickets, so the
option must only be set to 'sha256' once every node has that patch. The option
description says so. I did not add an automatic check against the node
versions (the new helpers in pve-cluster, 679cf2c, would allow one), as it
needs the release number that will contain 1/2. Happy to add one in
pve-manager's datacenter options update once that number is known.
Changes since v1: the option is new in v2. v1 switched signing to SHA-256
unconditionally, with an environment variable for the transition. Shannon
asked for opt-in, so FIPS users can enable it now, and a cluster-wide
datacenter.cfg option with default off was chosen. It is a plain enum, as the
hyphenated names of the newer options ('next-id', 'tag-style') suggest, and
leaves room for more hashes. The other v1 review points are in the pve-common
cover letter.
v1: <CALkZksWBSdQa5AsvhmANGAJigcZ7FHPtgRgdu3JsRt9NX6vwSg@mail.gmail.com>
This is sent as a new thread, as is usual for a new version of a series.
Thanks to Shannon Sterz for the review of v1.
Mark Atwood (1):
datacenter config: add ticket-signature-hash option
src/PVE/DataCenterConfig.pm | 16 +++++++++++
src/test/Makefile | 6 ++++-
src/test/test_ticket_signature_hash.pl | 37 ++++++++++++++++++++++++++
3 files changed, 58 insertions(+), 1 deletion(-)
create mode 100644 src/test/test_ticket_signature_hash.pl
base-commit: 679cf2c674254f41ddd89cc8e4e17d83c8444ad7
next reply other threads:[~2026-11-13 3:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 3:06 Mark Atwood [this message]
2026-11-13 3:06 ` [PATCH cluster v2 1/1] datacenter config: add ticket-signature-hash option Mark Atwood
2026-11-17 16:05 ` Shannon Sterz
2026-11-18 4:14 ` Thomas Lamprecht
2026-11-18 9:40 ` Shannon Sterz
2026-11-19 12:38 ` Thomas Lamprecht
2026-11-19 13:37 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113030646.3533-1-mark@wolfssl.com \
--to=mark@wolfssl.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox