Re: [PATCH manager] ui: MultiDiskPanel: fix default LXC rootfs disk missing

[Dominik Csapak <d.csapak@proxmox.com>]

mhmm.. not sure if this is better of if we simply set the nodename also 
in the lxc wizard, the diff would be vastly smaller and we'd
use the same codpath for both qemu and lxc:

---
diff --git a/www/manager6/lxc/CreateWizard.js 
b/www/manager6/lxc/CreateWizard.js
index 638a0415..f0d91892 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -234,6 +234,9 @@ Ext.define('PVE.lxc.CreateWizard', {
              isCreate: true,
              unused: false,
              confid: 'rootfs',
+            bind: {
+                nodename: '{nodename}',
+            },
          },
          {
              xtype: 'pveLxcCPUInputPanel',
---

On 5/19/26 10:58 AM, Filip Schauer wrote:
> Commit aecf27bd moved the initial disk addition from afterrender to
> setNodename so that architecture-specific defaults are available when
> the first disk is added in the VM creation wizard. However, the LXC
> wizard never calls setNodename on the MultiMPPanel, so the initial disk
> was never added and the Disks tab appeared empty.
> 
> Restore the afterrender fallback, gated on addedFirstDisk, so it is a
> no-op when setNodename already fired but still triggers otherwise.
> 
> Fixes: aecf27bd (fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive)
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
>   www/manager6/panel/MultiDiskEdit.js | 13 ++++++++++---
>   1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/www/manager6/panel/MultiDiskEdit.js b/www/manager6/panel/MultiDiskEdit.js
> index 3de07674..b202f3ac 100644
> --- a/www/manager6/panel/MultiDiskEdit.js
> +++ b/www/manager6/panel/MultiDiskEdit.js
> @@ -33,9 +33,7 @@ Ext.define('PVE.panel.MultiDiskPanel', {
>               let me = this;
>               let view = me.getView();
>               me.addDiskChecked(false);
> -            if (!view.addedFirstDisk) {
> -                view.addedFirstDisk = true;
> -            }
> +            view.addedFirstDisk = true;
>           },
>   
>           onImport: function () {
> @@ -225,6 +223,15 @@ Ext.define('PVE.panel.MultiDiskPanel', {
>               'grid[reference=grid]': {
>                   selectionchange: 'onSelectionChange',
>               },
> +            '#': {
> +                afterrender: function (view) {
> +                    let me = this;
> +                    if (!view.addedFirstDisk) {
> +                        me.onAdd();
> +                        me.lookup('grid').getSelectionModel().select(0, false);
> +                    }
> +                },
> +            },
>           },
>       },
>