public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] ui: MultiDiskPanel: fix default LXC rootfs disk missing
Date: Tue, 19 May 2026 10:58:56 +0200	[thread overview]
Message-ID: <20260519085858.45500-1-f.schauer@proxmox.com> (raw)

Commit aecf27bd moved the initial disk addition from afterrender to
setNodename so that architecture-specific defaults are available when
the first disk is added in the VM creation wizard. However, the LXC
wizard never calls setNodename on the MultiMPPanel, so the initial disk
was never added and the Disks tab appeared empty.

Restore the afterrender fallback, gated on addedFirstDisk, so it is a
no-op when setNodename already fired but still triggers otherwise.

Fixes: aecf27bd (fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive)
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
 www/manager6/panel/MultiDiskEdit.js | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/www/manager6/panel/MultiDiskEdit.js b/www/manager6/panel/MultiDiskEdit.js
index 3de07674..b202f3ac 100644
--- a/www/manager6/panel/MultiDiskEdit.js
+++ b/www/manager6/panel/MultiDiskEdit.js
@@ -33,9 +33,7 @@ Ext.define('PVE.panel.MultiDiskPanel', {
             let me = this;
             let view = me.getView();
             me.addDiskChecked(false);
-            if (!view.addedFirstDisk) {
-                view.addedFirstDisk = true;
-            }
+            view.addedFirstDisk = true;
         },
 
         onImport: function () {
@@ -225,6 +223,15 @@ Ext.define('PVE.panel.MultiDiskPanel', {
             'grid[reference=grid]': {
                 selectionchange: 'onSelectionChange',
             },
+            '#': {
+                afterrender: function (view) {
+                    let me = this;
+                    if (!view.addedFirstDisk) {
+                        me.onAdd();
+                        me.lookup('grid').getSelectionModel().select(0, false);
+                    }
+                },
+            },
         },
     },
 
-- 
2.47.3





             reply	other threads:[~2026-05-19  8:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  8:58 Filip Schauer [this message]
2026-05-19  9:11 ` [PATCH manager] ui: MultiDiskPanel: fix default LXC rootfs disk missing Dominik Csapak
2026-05-19  9:27   ` Filip Schauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519085858.45500-1-f.schauer@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal