From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6D89A1FF141 for ; Tue, 19 May 2026 11:12:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CD00536740; Tue, 19 May 2026 11:12:26 +0200 (CEST) Message-ID: <2559bfae-6682-4ba1-a87b-c55d04bbc2da@proxmox.com> Date: Tue, 19 May 2026 11:11:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager] ui: MultiDiskPanel: fix default LXC rootfs disk missing To: Filip Schauer , pve-devel@lists.proxmox.com References: <20260519085858.45500-1-f.schauer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260519085858.45500-1-f.schauer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779181896820 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XTNN7AZRKQNGVIYB5UGTPHIXBEQQYRAB X-Message-ID-Hash: XTNN7AZRKQNGVIYB5UGTPHIXBEQQYRAB X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: mhmm.. not sure if this is better of if we simply set the nodename also in the lxc wizard, the diff would be vastly smaller and we'd use the same codpath for both qemu and lxc: --- diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js index 638a0415..f0d91892 100644 --- a/www/manager6/lxc/CreateWizard.js +++ b/www/manager6/lxc/CreateWizard.js @@ -234,6 +234,9 @@ Ext.define('PVE.lxc.CreateWizard', { isCreate: true, unused: false, confid: 'rootfs', + bind: { + nodename: '{nodename}', + }, }, { xtype: 'pveLxcCPUInputPanel', --- On 5/19/26 10:58 AM, Filip Schauer wrote: > Commit aecf27bd moved the initial disk addition from afterrender to > setNodename so that architecture-specific defaults are available when > the first disk is added in the VM creation wizard. However, the LXC > wizard never calls setNodename on the MultiMPPanel, so the initial disk > was never added and the Disks tab appeared empty. > > Restore the afterrender fallback, gated on addedFirstDisk, so it is a > no-op when setNodename already fired but still triggers otherwise. > > Fixes: aecf27bd (fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive) > Signed-off-by: Filip Schauer > --- > www/manager6/panel/MultiDiskEdit.js | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/www/manager6/panel/MultiDiskEdit.js b/www/manager6/panel/MultiDiskEdit.js > index 3de07674..b202f3ac 100644 > --- a/www/manager6/panel/MultiDiskEdit.js > +++ b/www/manager6/panel/MultiDiskEdit.js > @@ -33,9 +33,7 @@ Ext.define('PVE.panel.MultiDiskPanel', { > let me = this; > let view = me.getView(); > me.addDiskChecked(false); > - if (!view.addedFirstDisk) { > - view.addedFirstDisk = true; > - } > + view.addedFirstDisk = true; > }, > > onImport: function () { > @@ -225,6 +223,15 @@ Ext.define('PVE.panel.MultiDiskPanel', { > 'grid[reference=grid]': { > selectionchange: 'onSelectionChange', > }, > + '#': { > + afterrender: function (view) { > + let me = this; > + if (!view.addedFirstDisk) { > + me.onAdd(); > + me.lookup('grid').getSelectionModel().select(0, false); > + } > + }, > + }, > }, > }, >