public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v5 34/41] api: bulk migrate: refuse targets that would drop the guest identity
Date: Thu, 19 Nov 2026 20:19:06 +0100	[thread overview]
Message-ID: <20261119191914.2336934-35-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261119191914.2336934-1-t.lamprecht@proxmox.com>

A node that keeps the guest identity refuses to migrate a guest to a
node that does not. A bulk migration to such a node therefore logged one
warning per guest and only failed after it had tried all of them. Check
the target once, before the task starts.

The migration of all guests of a node runs on that node. The check there
gives the same result as the check of each single migration.

The cluster-wide bulk migration is different. It runs on the node that
handles the request, while each guest migrates from its own node, and a
source node with an older version does not check the target at all. So
refuse there only if at least one selected guest that is not on the
target yet is on a node that keeps the identity. Guests can then still
move between two older nodes, for example to empty a node before its
upgrade. Check first that the target node exists, because the version
check would report a mistyped node name as a node without version
information.

Add a test for the cluster-wide check with sources and targets of both
kinds.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
---

changes v4 -> v5:
* new test for the cluster-wide check, with source and target nodes of
  both kinds
* one comment reworded

changes v3 -> v4:
* cluster-wide bulk migration: refuse up front only if a selected guest
  that is not on the target yet sits on a node that keeps the identity,
  so that guests can still move between two older nodes, for example to
  empty one before its upgrade; v3 refused that
* commit message: plainer wording, same content

changes v2 -> v3:
* also check the target of the cluster-wide bulk migration once before
  the task starts, after checking that the node exists; subject changed
  accordingly

changes v1 -> v2:
* new in v2

 PVE/API2/Cluster/BulkAction/Guest.pm |  17 +++++
 PVE/API2/Nodes.pm                    |   3 +
 test/BulkMigrate_test.pl             | 102 +++++++++++++++++++++++++++
 test/Makefile                        |   6 +-
 4 files changed, 127 insertions(+), 1 deletion(-)
 create mode 100755 test/BulkMigrate_test.pl

diff --git a/PVE/API2/Cluster/BulkAction/Guest.pm b/PVE/API2/Cluster/BulkAction/Guest.pm
index a55ea2ea..a2e92d14 100644
--- a/PVE/API2/Cluster/BulkAction/Guest.pm
+++ b/PVE/API2/Cluster/BulkAction/Guest.pm
@@ -6,6 +6,7 @@ use warnings;
 use PVE::APIClient::LWP;
 use PVE::Cluster;
 use PVE::Exception qw(raise raise_perm_exc raise_param_exc);
+use PVE::GuestIdentity;
 use PVE::INotify;
 use PVE::JSONSchema qw(get_standard_option);
 use PVE::RESTEnvironment qw(log_warn);
@@ -760,6 +761,22 @@ __PACKAGE__->register_method({
 
         check_guest_permissions($rpcenv, $authuser, $vmlist, ['VM.Migrate']);
 
+        my $target = $param->{target};
+        PVE::Cluster::check_node_exists($target);
+
+        # A source node that keeps the guest identity refuses an older target for each guest, so
+        # refuse once instead. Older source nodes do not check the target, so do not refuse for them.
+        my $cluster_vmlist = PVE::Cluster::get_vmlist() // {};
+        my $guests = $cluster_vmlist->{ids} // {};
+        my $sources = {};
+        for my $vmid (scalar($vmlist->@*) ? $vmlist->@* : keys $guests->%*) {
+            my $node = $guests->{$vmid} ? $guests->{$vmid}->{node} : undef;
+            $sources->{$node} = 1 if defined($node) && $node ne $target;
+        }
+        if (grep { !PVE::GuestIdentity::node_identity_unsupported($_) } keys $sources->%*) {
+            PVE::GuestIdentity::assert_node_supports_identity($target);
+        }
+
         my $code = sub {
             my $list =
                 PVE::API2::Nodes::Nodeinfo::get_filtered_vmlist(undef, $vmlist_string, 1, 1);
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 07b3ce1f..8dc409bf 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -23,6 +23,7 @@ use PVE::Cluster qw(cfs_read_file);
 use PVE::DataCenterConfig;
 use PVE::Exception qw(raise raise_perm_exc raise_param_exc);
 use PVE::Firewall;
+use PVE::GuestIdentity;
 use PVE::HA::Config;
 use PVE::HA::Env::PVE2;
 use PVE::INotify;
@@ -2766,6 +2767,8 @@ __PACKAGE__->register_method({
         PVE::Cluster::check_cfs_quorum();
 
         PVE::Cluster::check_node_exists($target);
+        # refuse once instead of failing the migration of every guest
+        PVE::GuestIdentity::assert_node_supports_identity($target);
 
         my $datacenterconfig = cfs_read_file('datacenter.cfg');
         # prefer parameter over datacenter cfg settings
diff --git a/test/BulkMigrate_test.pl b/test/BulkMigrate_test.pl
new file mode 100755
index 00000000..dfacf95a
--- /dev/null
+++ b/test/BulkMigrate_test.pl
@@ -0,0 +1,102 @@
+#!/usr/bin/perl
+
+use v5.36;
+
+use lib ('.', '..');
+
+use JSON;
+use Test::MockModule;
+use Test::More;
+
+use PVE::GuestIdentity;
+use PVE::RPCEnvironment;
+
+use PVE::API2::Cluster::BulkAction::Guest;
+
+my $new = PVE::GuestIdentity::MIN_PVE_MANAGER_VERSION;
+# the Proxmox VE version that each node reports, 'unknown' reports none
+my $versions = { old1 => '9.1.1', old2 => '9.1.1', new1 => $new, new2 => $new };
+my $default_guests = { 100 => 'old1', 101 => 'new1', 102 => 'old2', 103 => 'new2' };
+my $guests; # VMID to node
+
+my $cluster_mock = Test::MockModule->new('PVE::Cluster');
+$cluster_mock->redefine(
+    check_node_exists => sub { },
+    get_vmlist => sub {
+        return {
+            ids => { map { $_ => { node => $guests->{$_}, type => 'qemu' } } keys %$guests } };
+    },
+    get_node_kv => sub($key, $node) {
+        return {} if !defined($versions->{$node});
+        return { $node => encode_json({ version => $versions->{$node} }) };
+    },
+);
+
+my $started; # whether the handler got to start the migration task
+my $rpcenv = bless {}, 'PVE::RPCEnvironment';
+my $rpcenv_mock = Test::MockModule->new('PVE::RPCEnvironment');
+$rpcenv_mock->redefine(
+    get => sub { return $rpcenv },
+    get_user => sub { return 'root@pam' },
+    check => sub { return 1 },
+    fork_worker => sub { $started = 1; return 'UPID:test' },
+);
+
+my $method = PVE::API2::Cluster::BulkAction::Guest->map_method_by_name('migrate');
+
+my $too_old = qr/^node 'old2' runs Proxmox VE 9\.1\.1, keeping the guest identity requires/;
+
+for my $case (
+    { name => 'older source, older target', vms => [100], target => 'old2' },
+    {
+        name => 'newer source, older target',
+        vms => [101],
+        target => 'old2',
+        refused => $too_old,
+    },
+    { name => 'newer source, newer target', vms => [101], target => 'new2' },
+    { name => 'older source, newer target', vms => [100], target => 'new2' },
+    {
+        name => 'older and newer source, older target',
+        vms => [100, 101],
+        target => 'old2',
+        refused => $too_old,
+    },
+    {
+        name => 'newer source, target without version',
+        vms => [101],
+        target => 'unknown',
+        refused => qr/^node 'unknown' does not report its Proxmox VE version/,
+    },
+    { name => 'older source, target without version', vms => [100], target => 'unknown' },
+    { name => 'guest that is on the older target already', vms => [102], target => 'old2' },
+    { name => 'guest that does not exist', vms => [999], target => 'old2' },
+    { name => 'all guests, older target', target => 'old2', refused => $too_old },
+    { name => 'all guests, newer target', target => 'new2' },
+    {
+        name => 'all guests on older nodes, older target',
+        guests => { 100 => 'old1', 102 => 'old2' },
+        target => 'old2',
+    },
+    { name => 'no guests, older target', guests => {}, target => 'old2' },
+) {
+    subtest $case->{name} => sub {
+        $guests = $case->{guests} // $default_guests;
+        $started = 0;
+
+        my $param = { target => $case->{target} };
+        $param->{vms} = $case->{vms} if $case->{vms};
+        eval { PVE::API2::Cluster::BulkAction::Guest->handle($method, $param) };
+        my $err = $@;
+
+        if (my $refused = $case->{refused}) {
+            like($err, $refused, 'target is refused');
+            ok(!$started, 'no task is started');
+        } else {
+            is($err, '', 'target is not refused');
+            ok($started, 'task is started');
+        }
+    };
+}
+
+done_testing();
diff --git a/test/Makefile b/test/Makefile
index 64bf8e4e..ef9b20f2 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -5,7 +5,7 @@ all:
 export PERLLIB=..
 
 .PHONY: check
-check: test-replication test-balloon test-vzdump test-osd test-ceph-health test-ceph-services test-ceph-auth test-ceph-key-migration test-ceph-lockbox-migration test-custom-cpu-models test-pvesh test-report test-access-log test-cluster-resources test-cluster-status
+check: test-replication test-balloon test-vzdump test-osd test-ceph-health test-ceph-services test-ceph-auth test-ceph-key-migration test-ceph-lockbox-migration test-custom-cpu-models test-pvesh test-report test-access-log test-cluster-resources test-cluster-status test-bulk-migrate
 
 .PHONY: test-balloon
 test-balloon:
@@ -77,6 +77,10 @@ test-cluster-resources:
 test-cluster-status:
 	./ClusterStatus_test.pl
 
+.PHONY: test-bulk-migrate
+test-bulk-migrate:
+	./BulkMigrate_test.pl
+
 .PHONY: install
 install:
 
-- 
2.47.3





  parent reply	other threads:[~2026-11-19 19:24 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 19:18 [PATCH cluster/guest-common/qemu-server/container/manager/docs v5 00/41] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 01/41] pmxcfs: reject changes to the cluster ID file from user space Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 02/41] pmxcfs: generate a cluster ID on standalone nodes Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 03/41] pmxcfs: dfsm: add a callback that runs once all members are in sync Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 04/41] pmxcfs: quorum: record the corosync membership Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 05/41] pmxcfs: dcdb: generate the cluster ID once the cluster is in sync Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 06/41] cluster: add helper to read the cluster ID Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 07/41] pmxcfs: allow removing the cluster ID file in forced local mode Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 08/41] guest identity: add helpers for the guest uid and registration time Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 09/41] abstract config: assign a guest identity and keep it on config writes Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 10/41] abstract config: let the VMID reservation return the previous state Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 11/41] guest identity: allow adopting a uid that is unused in the cluster Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 12/41] migrate: add shared helpers for the identity command of the migration tunnel Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 13/41] vzdump: notes template: list the uid variable Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 14/41] api: restore: release the VMID if a restore to an unused VMID fails Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 15/41] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 16/41] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 17/41] restore: adopt the guest uid from the backup where possible Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 18/41] api: remote migration: adopt the guest uid from the source Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 19/41] api: status: return the guest uid Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 20/41] restore: decide by the reservation whether the container is new Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 21/41] config: add read-only meta property with the creation time Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 22/41] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 23/41] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 24/41] restore: adopt the guest uid from the backup where possible Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 25/41] restore: refuse overwriting a container with another guest's backup Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 26/41] api: remote migration: adopt the guest uid from the source Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 27/41] api: status: return the guest uid Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 28/41] api: cluster resources: add guest uid and registration time Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 29/41] api: cluster status: add cluster ID Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 30/41] ui: datacenter summary: show the " Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 31/41] ui: restore: allow overwriting a guest with a backup of another guest Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 32/41] ui: migrate: refuse target nodes that would drop the guest identity Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 33/41] ui: guest summary: show " Thomas Lamprecht
2026-11-19 19:19 ` Thomas Lamprecht [this message]
2026-11-19 19:19 ` [PATCH manager v5 35/41] vzdump: notes template: add the guest uid as variable Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 36/41] vzdump: restore: describe what a failed restore can leave behind Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 37/41] vzdump: describe the guest identity of VMs and containers Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 38/41] pvecm: document the cluster ID and how to get a new one Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 39/41] qm: configuration: describe the read-only meta property Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 40/41] pct: " Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 41/41] vzdump: notes: document the uid template variable Thomas Lamprecht
2026-11-20  3:07 ` [PATCH cluster/guest-common/qemu-server/container/manager/docs v5 00/41] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119191914.2336934-35-t.lamprecht@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal