public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [PATCH cluster/guest-common/qemu-server/container/manager/docs v5 00/41] fix #7846: guest identity (uid) and cluster ID
Date: Fri, 20 Nov 2026 04:07:36 +0100	[thread overview]
Message-ID: <179514371983.3042193.10763941419621803691.b4-ty@proxmox.com> (raw)
In-Reply-To: <20261119191914.2336934-1-t.lamprecht@proxmox.com>

On Thu, 19 Nov 2026 20:18:32 +0100, Thomas Lamprecht wrote:
> A VMID can be reused for another guest, and a guest can get another
> VMID or move to another cluster through a restore or a remote
> migration. So backup software and other tools cannot tell whether they
> still look at the same guest, see [0].
> 
> This series gives every VM and container a guest identity in the
> read-only 'meta' property: a random uid (100 bits as 20 base32
> characters) and the time the guest was registered in the cluster. Create
> and clone get a new uid. Config changes, migration, rollback, backup and
> restore keep it, also under another VMID or in another cluster, as long
> as no other guest there has it. Each cluster or standalone node also
> gets a cluster ID in the same format, generated and protected by pmxcfs.
> The docs patches describe the details.
> 
> [...]

Applied, thanks @Dominik for the reviews!

Relevant changes on top of v5:

- ui: restore: the 'Allow restoring a backup of another guest' checkbox
  only shows if the backup and the guest have different uids, together
  with a hint, or if the window cannot compare them.
- container restore: extract the backup file through the handle that was
  opened to read its config, without looking up its path again. A backup
  that a prune job removed in between no longer makes the restore fail
  after it destroyed the old container.
- backup providers get the guest uid and the cluster ID as 'guest-uid'
  and 'cluster-id' in the info hash of the backup calls, with new
  commits in qemu-server and pve-container, documented in pve-storage.
- container config: refuse writing a value with a null character, as the
  pmxcfs lookup that the uid uniqueness check uses would cut it short.
- qmextract: fail if a restored volume of a legacy tar archive cannot be
  recorded, instead of keeping the drive line of the backup, which names
  a disk of the original VM.

The HA change, which checks the target before an HA move stops a guest,
is sent separately:
https://lore.proxmox.com/20261120025517.3031086-1-t.lamprecht@proxmox.com

[01/41] pmxcfs: reject changes to the cluster ID file from user space
        commit: 80bfea496eea6b2f2d6dad0aeb8d0779ce4e6887
[02/41] pmxcfs: generate a cluster ID on standalone nodes
        commit: 08af730be735a4bb53ebbc810dcad86292296595
[03/41] pmxcfs: dfsm: add a callback that runs once all members are in sync
        commit: e8ab9df65539d96036dbfabddc470d714b2998a3
[04/41] pmxcfs: quorum: record the corosync membership
        commit: 29bdd4a38eaba6a479f2b540b6d9b9ca98c72b78
[05/41] pmxcfs: dcdb: generate the cluster ID once the cluster is in sync
        commit: 00d3623ac7dca7fd4f3182e1799b2ebaebb16078
[06/41] cluster: add helper to read the cluster ID
        commit: abe3f3255d63cd0cfa6cb6787dd8b2e5ea401422
[07/41] pmxcfs: allow removing the cluster ID file in forced local mode
        commit: 2b3f8b7958a1512992d60fe043ffc0c96e37ade7
[08/41] guest identity: add helpers for the guest uid and registration time
        commit: d6abe33d85d4fba903e9b20e2b220fe8acdfb8d6
[09/41] abstract config: assign a guest identity and keep it on config writes
        commit: ceb4de65f8daf518926c11107e1d254f9cd8c5e7
[10/41] abstract config: let the VMID reservation return the previous state
        commit: b3c31bfdd4872412fdf603b55a6e33e2ed7be606
[11/41] guest identity: allow adopting a uid that is unused in the cluster
        commit: 849d16c923048b3c4bca42188a4d6a3569abe930
[12/41] migrate: add shared helpers for the identity command of the migration tunnel
        commit: 470f2beb306cf045a46e7573bb26293de9e6062d
[13/41] vzdump: notes template: list the uid variable
        commit: f71c9aa5bcda4e64f767fa789fc203bb764595d7
[14/41] api: restore: release the VMID if a restore to an unused VMID fails
        commit: 74b4a27e41ae286b2108fee73314d34ae126b378
[15/41] api: migrate, clone: refuse targets that would drop the guest identity
        commit: 61feb80f3c7bec3390e4f7f259084520a796f7d5
[16/41] fix #7846: config: add a guest identity to the 'meta' property
        commit: ca8b246e51a3dbe9f605f32279889d133b17314d
[17/41] restore: adopt the guest uid from the backup where possible
        commit: e72b64d37c3a1392fe322b6823ca14791b5c3403
[18/41] api: remote migration: adopt the guest uid from the source
        commit: cd54b862cb6a53e7df84f7d95b866063e5fb6473
[19/41] api: status: return the guest uid
        commit: a6556ca3b894f6619a884b87d84611acd7df65d3
[20/41] restore: decide by the reservation whether the container is new
        commit: 591a5b2290bad28c9ab362ab275069bb5026876d
[21/41] config: add read-only meta property with the creation time
        commit: b8390705980392efe6de6f55c191e14d9b3d8cf5
[22/41] fix #7846: config: add a guest identity to the 'meta' property
        commit: 3ac61bcc3d5056a7089ffc4f5eb0adb0d49e7121
[23/41] api: migrate, clone: refuse targets that would drop the guest identity
        commit: 22efc2fc1f6c1e010e218747e157e87a892ebdd3
[24/41] restore: adopt the guest uid from the backup where possible
        commit: 1cb35f7af05b59195a4f69218eadcd0e840b1fd1
[25/41] restore: refuse overwriting a container with another guest's backup
        commit: 0bdfe1409ab0af658763319cc5c3cee17999fe87
[26/41] api: remote migration: adopt the guest uid from the source
        commit: 7872093384e596a7c1242f091e6bef5fe466d294
[27/41] api: status: return the guest uid
        commit: 6c00625d47ec2844425c2cff59f5e97de1680b1e
[28/41] api: cluster resources: add guest uid and registration time
        commit: edc625ee58da21ac2c2abbcf2543564b17e2b062
[29/41] api: cluster status: add cluster ID
        commit: 0b834c59ad0882b4eb8387e33674bba8d45b8170
[30/41] ui: datacenter summary: show the cluster ID
        commit: 8e228d11d1c0b4ea3ba8a312820d0da0d02b0905
[31/41] ui: restore: allow overwriting a guest with a backup of another guest
        commit: 7033417f0e07219a44efdcb1fdf6d303359e0dad
[32/41] ui: migrate: refuse target nodes that would drop the guest identity
        commit: 582f8751155f407328a31b2b50ef21426db648d7
[33/41] ui: guest summary: show the guest identity
        commit: 45ade9e2e1c64476e3cacbd111f24b8ef4d3c463
[34/41] api: bulk migrate: refuse targets that would drop the guest identity
        commit: 90f90c412189dcb050d59971279308ccfa814a6c
[35/41] vzdump: notes template: add the guest uid as variable
        commit: d16ed476671d1f3601d431e266bd2f78ee9bc322
[36/41] vzdump: restore: describe what a failed restore can leave behind
        commit: 546a2957c573701b38ab99989075cd22df59bcc6
[37/41] vzdump: describe the guest identity of VMs and containers
        commit: b78d0cf66f5b9a9cf755079418625af267c47408
[38/41] pvecm: document the cluster ID and how to get a new one
        commit: 24c02ec4adfbc7b84e55b242353970673d57d4ab
[39/41] qm: configuration: describe the read-only meta property
        commit: 3c8dd3271a2c0205bb6941af5291609f12bc684d
[40/41] pct: configuration: describe the read-only meta property
        commit: 442090df05a172414f7e4a952634047b81822534
[41/41] vzdump: notes: document the uid template variable
        commit: 09c13af8f3b82f721992175de2db348554cbd4e5




      parent reply	other threads:[~2026-11-20  3:13 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 19:18 [PATCH cluster/guest-common/qemu-server/container/manager/docs v5 00/41] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 01/41] pmxcfs: reject changes to the cluster ID file from user space Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 02/41] pmxcfs: generate a cluster ID on standalone nodes Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 03/41] pmxcfs: dfsm: add a callback that runs once all members are in sync Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 04/41] pmxcfs: quorum: record the corosync membership Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 05/41] pmxcfs: dcdb: generate the cluster ID once the cluster is in sync Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 06/41] cluster: add helper to read the cluster ID Thomas Lamprecht
2026-11-19 19:18 ` [PATCH cluster v5 07/41] pmxcfs: allow removing the cluster ID file in forced local mode Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 08/41] guest identity: add helpers for the guest uid and registration time Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 09/41] abstract config: assign a guest identity and keep it on config writes Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 10/41] abstract config: let the VMID reservation return the previous state Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 11/41] guest identity: allow adopting a uid that is unused in the cluster Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 12/41] migrate: add shared helpers for the identity command of the migration tunnel Thomas Lamprecht
2026-11-19 19:18 ` [PATCH guest-common v5 13/41] vzdump: notes template: list the uid variable Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 14/41] api: restore: release the VMID if a restore to an unused VMID fails Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 15/41] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 16/41] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 17/41] restore: adopt the guest uid from the backup where possible Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 18/41] api: remote migration: adopt the guest uid from the source Thomas Lamprecht
2026-11-19 19:18 ` [PATCH qemu-server v5 19/41] api: status: return the guest uid Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 20/41] restore: decide by the reservation whether the container is new Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 21/41] config: add read-only meta property with the creation time Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 22/41] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 23/41] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 24/41] restore: adopt the guest uid from the backup where possible Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 25/41] restore: refuse overwriting a container with another guest's backup Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 26/41] api: remote migration: adopt the guest uid from the source Thomas Lamprecht
2026-11-19 19:18 ` [PATCH container v5 27/41] api: status: return the guest uid Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 28/41] api: cluster resources: add guest uid and registration time Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 29/41] api: cluster status: add cluster ID Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 30/41] ui: datacenter summary: show the " Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 31/41] ui: restore: allow overwriting a guest with a backup of another guest Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 32/41] ui: migrate: refuse target nodes that would drop the guest identity Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 33/41] ui: guest summary: show " Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 34/41] api: bulk migrate: refuse targets that would drop " Thomas Lamprecht
2026-11-19 19:19 ` [PATCH manager v5 35/41] vzdump: notes template: add the guest uid as variable Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 36/41] vzdump: restore: describe what a failed restore can leave behind Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 37/41] vzdump: describe the guest identity of VMs and containers Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 38/41] pvecm: document the cluster ID and how to get a new one Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 39/41] qm: configuration: describe the read-only meta property Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 40/41] pct: " Thomas Lamprecht
2026-11-19 19:19 ` [PATCH docs v5 41/41] vzdump: notes: document the uid template variable Thomas Lamprecht
2026-11-20  3:07 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179514371983.3042193.10763941419621803691.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal