From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v7 0/2] hotplug: improve and fix cleanup/error handling
Date: Thu, 5 Nov 2026 09:22:13 +0100 [thread overview]
Message-ID: <20261105082524.428152-1-d.csapak@proxmox.com> (raw)
This replaces my earlier v4 9/9 patch[0]
It uses a different approach now by unifying the cleanup and removal of
disks and their controllers.
changes from v6:
* call print_drivedevice_full before adding the SCSI controller, so a
volume rejected by the storage layer (e.g. a vanished storage) does
not cause a controller plug/unplug cycle, and add a test for it
* add a test for a failed disk hotplug on a shared SCSI controller,
which must keep the controller for the remaining disks
changes from v5:
* rebase on master
* rename helper to 'delete_disk_hardware'
* don't eval the individual calls, but always the whole function
(drops noerr parameter)
changes from v4:
* rebase on master
* new bugfix (1/4)
* new patch for iothread deletion
* new patch for refactoring the cleanup
0: https://lore.proxmox.com/pve-devel/20261023130324.451252-10-d.csapak@proxmox.com/
Dominik Csapak (2):
hotplug: factor out cleanup of disk devices
hotplug: clean up disk devices/objects if adding them failed
src/PVE/QemuServer.pm | 75 ++++++++++++-------
src/test/hotplug/disk-add-fail.conf | 19 +++++
src/test/hotplug/disk-add-fail.conf.expected | 10 +++
src/test/hotplug/disk-add-fail2.conf | 17 +++++
src/test/hotplug/disk-add-fail2.conf.expected | 1 +
.../disk-add-scsi-shared-controller-fail.conf | 19 +++++
...-scsi-shared-controller-fail.conf.expected | 8 ++
.../disk-add-scsi-single-disk-fail.conf | 19 +++++
...sk-add-scsi-single-disk-fail.conf.expected | 12 +++
.../hotplug/disk-add-scsi-single-fail.conf | 19 +++++
.../disk-add-scsi-single-fail.conf.expected | 5 ++
11 files changed, 175 insertions(+), 29 deletions(-)
create mode 100644 src/test/hotplug/disk-add-fail.conf
create mode 100644 src/test/hotplug/disk-add-fail.conf.expected
create mode 100644 src/test/hotplug/disk-add-fail2.conf
create mode 100644 src/test/hotplug/disk-add-fail2.conf.expected
create mode 100644 src/test/hotplug/disk-add-scsi-shared-controller-fail.conf
create mode 100644 src/test/hotplug/disk-add-scsi-shared-controller-fail.conf.expected
create mode 100644 src/test/hotplug/disk-add-scsi-single-disk-fail.conf
create mode 100644 src/test/hotplug/disk-add-scsi-single-disk-fail.conf.expected
create mode 100644 src/test/hotplug/disk-add-scsi-single-fail.conf
create mode 100644 src/test/hotplug/disk-add-scsi-single-fail.conf.expected
--
2.47.3
next reply other threads:[~2026-11-05 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 8:22 Dominik Csapak [this message]
2026-11-05 8:22 ` [PATCH qemu-server v7 1/2] hotplug: factor out cleanup of disk devices Dominik Csapak
2026-11-05 8:22 ` [PATCH qemu-server v7 2/2] hotplug: clean up disk devices/objects if adding them failed Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105082524.428152-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox