From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH proxmox 3/3] pve-api-types: enable strict and warnings in Bool
Date: Thu, 15 Oct 2026 17:42:41 +0200 [thread overview]
Message-ID: <20261015154243.304235-4-l.sichert@proxmox.com> (raw)
In-Reply-To: <20261015154243.304235-1-l.sichert@proxmox.com>
The Proxmox style guide requires every perl module to enable both
pragmas, but Bool.pm did not. Enable them so that mistakes made when
extending the module are reported instead of silently ignored.
Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
pve-api-types/generator-lib/Bool.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/pve-api-types/generator-lib/Bool.pm b/pve-api-types/generator-lib/Bool.pm
index 12a4e156..ac242592 100644
--- a/pve-api-types/generator-lib/Bool.pm
+++ b/pve-api-types/generator-lib/Bool.pm
@@ -1,5 +1,8 @@
package Bool;
+use strict;
+use warnings;
+
use base 'Exporter';
use overload
'!' => sub { bool(!$_[0]->$*) },
--
2.47.3
prev parent reply other threads:[~2026-10-15 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 15:42 [PATCH network/perl-rs/proxmox 0/3] perl: enable strict and warnings in modules that lack them Lukas Sichert
2026-10-15 15:42 ` [PATCH network 1/3] api: zones: enable strict and warnings Lukas Sichert
2026-10-15 15:42 ` [PATCH perl-rs 2/3] common: enable strict and warnings in perl package modules Lukas Sichert
2026-10-16 13:43 ` Wolfgang Bumiller
2026-10-15 15:42 ` Lukas Sichert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015154243.304235-4-l.sichert@proxmox.com \
--to=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox