From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 0C28F1FF0BC for ; Thu, 15 Oct 2026 17:43:24 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1274621643; Thu, 15 Oct 2026 17:42:57 +0200 (CEST) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox 3/3] pve-api-types: enable strict and warnings in Bool Date: Thu, 15 Oct 2026 17:42:41 +0200 Message-ID: <20261015154243.304235-4-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261015154243.304235-1-l.sichert@proxmox.com> References: <20261015154243.304235-1-l.sichert@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792078971659 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.627 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: U5UE6HLSL6YAY4BTYWMWZTADB7JXELLB X-Message-ID-Hash: U5UE6HLSL6YAY4BTYWMWZTADB7JXELLB X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The Proxmox style guide requires every perl module to enable both pragmas, but Bool.pm did not. Enable them so that mistakes made when extending the module are reported instead of silently ignored. Signed-off-by: Lukas Sichert --- pve-api-types/generator-lib/Bool.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pve-api-types/generator-lib/Bool.pm b/pve-api-types/generator-lib/Bool.pm index 12a4e156..ac242592 100644 --- a/pve-api-types/generator-lib/Bool.pm +++ b/pve-api-types/generator-lib/Bool.pm @@ -1,5 +1,8 @@ package Bool; +use strict; +use warnings; + use base 'Exporter'; use overload '!' => sub { bool(!$_[0]->$*) }, -- 2.47.3