public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH network/perl-rs/proxmox 0/3] perl: enable strict and warnings in modules that lack them
Date: Thu, 15 Oct 2026 17:42:38 +0200	[thread overview]
Message-ID: <20261015154243.304235-1-l.sichert@proxmox.com> (raw)

A scan of the perl modules in these repositories found a few that
enable neither 'use v5.36' nor 'use strict' and 'use warnings'. Enable
them to adhere to the style guide and so that mistakes such as typos
in variable names or uses of undefined values do not go unnoticed.

The Fixup.pm files in pve-rs and pmg-rs are intentionally left alone.
They are not modules of their own, but snippets that perlmod's
genpackage.pl inserts into the generated Proxmox::Lib::PVE and
Proxmox::Lib::PMG right after the 'use strict; use warnings;' of its
template, so they already run under both pragmas.

Testing:
- proxmox: running 'make refresh' in pve-api-types before and after the
  change generates identical output and identical stderr.
- proxmox-perl-rs: generated the Proxmox::RS::* modules by running
  'make Proxmox/RS' in common/pkg and loaded Proxmox::RS::CalendarEvent
  and PVE::RS::CalendarEvent with warnings made fatal using 'perl -e'.
  Loading CalendarEvent runs Proxmox::Lib::Common, and neither errors
  nor warnings were reported.
- pve-network: I installed the patched package on a test node and
  played around with the zones. I noticed the error messages
  'INTERFACE_STATE: Cannot find IF vrf_evpn45 in VRF 20' and 'Cannot
  process L3VNI 45 Del: Could not find BGP instance'. These messages
  were already present before this series and are therefore not caused
  by the added pragmas.


network:

Lukas Sichert (1):
  api: zones: enable strict and warnings

 src/PVE/API2/Network/SDN/Nodes/Zones.pm | 3 +++
 1 file changed, 3 insertions(+)


perl-rs:

Lukas Sichert (1):
  common: enable strict and warnings in perl package modules

 common/pkg/PVE/RS/CalendarEvent.pm | 3 +++
 common/pkg/Proxmox/Lib/Common.pm   | 3 +++
 2 files changed, 6 insertions(+)


proxmox:

Lukas Sichert (1):
  pve-api-types: enable strict and warnings in Bool

 pve-api-types/generator-lib/Bool.pm | 3 +++
 1 file changed, 3 insertions(+)


Summary over all repositories:
  4 files changed, 12 insertions(+), 0 deletions(-)

-- 
Generated by murpp 0.12.0




             reply	other threads:[~2026-10-15 15:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 15:42 Lukas Sichert [this message]
2026-10-15 15:42 ` [PATCH network 1/3] api: zones: enable strict and warnings Lukas Sichert
2026-10-15 15:42 ` [PATCH perl-rs 2/3] common: enable strict and warnings in perl package modules Lukas Sichert
2026-10-16 13:43   ` Wolfgang Bumiller
2026-10-15 15:42 ` [PATCH proxmox 3/3] pve-api-types: enable strict and warnings in Bool Lukas Sichert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015154243.304235-1-l.sichert@proxmox.com \
    --to=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal