From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id DEF761FF0BC for ; Thu, 15 Oct 2026 17:43:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BDCDF2151E; Thu, 15 Oct 2026 17:42:54 +0200 (CEST) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH network/perl-rs/proxmox 0/3] perl: enable strict and warnings in modules that lack them Date: Thu, 15 Oct 2026 17:42:38 +0200 Message-ID: <20261015154243.304235-1-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792078969365 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.644 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XRJWOHFXE6L6AD43D6SDTC6H3NRSQOPX X-Message-ID-Hash: XRJWOHFXE6L6AD43D6SDTC6H3NRSQOPX X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A scan of the perl modules in these repositories found a few that enable neither 'use v5.36' nor 'use strict' and 'use warnings'. Enable them to adhere to the style guide and so that mistakes such as typos in variable names or uses of undefined values do not go unnoticed. The Fixup.pm files in pve-rs and pmg-rs are intentionally left alone. They are not modules of their own, but snippets that perlmod's genpackage.pl inserts into the generated Proxmox::Lib::PVE and Proxmox::Lib::PMG right after the 'use strict; use warnings;' of its template, so they already run under both pragmas. Testing: - proxmox: running 'make refresh' in pve-api-types before and after the change generates identical output and identical stderr. - proxmox-perl-rs: generated the Proxmox::RS::* modules by running 'make Proxmox/RS' in common/pkg and loaded Proxmox::RS::CalendarEvent and PVE::RS::CalendarEvent with warnings made fatal using 'perl -e'. Loading CalendarEvent runs Proxmox::Lib::Common, and neither errors nor warnings were reported. - pve-network: I installed the patched package on a test node and played around with the zones. I noticed the error messages 'INTERFACE_STATE: Cannot find IF vrf_evpn45 in VRF 20' and 'Cannot process L3VNI 45 Del: Could not find BGP instance'. These messages were already present before this series and are therefore not caused by the added pragmas. network: Lukas Sichert (1): api: zones: enable strict and warnings src/PVE/API2/Network/SDN/Nodes/Zones.pm | 3 +++ 1 file changed, 3 insertions(+) perl-rs: Lukas Sichert (1): common: enable strict and warnings in perl package modules common/pkg/PVE/RS/CalendarEvent.pm | 3 +++ common/pkg/Proxmox/Lib/Common.pm | 3 +++ 2 files changed, 6 insertions(+) proxmox: Lukas Sichert (1): pve-api-types: enable strict and warnings in Bool pve-api-types/generator-lib/Bool.pm | 3 +++ 1 file changed, 3 insertions(+) Summary over all repositories: 4 files changed, 12 insertions(+), 0 deletions(-) -- Generated by murpp 0.12.0