public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-mamager v3 0/3] fix #8031: Write APT proxy config on http_proxy change
Date: Mon, 12 Oct 2026 16:45:33 +0200	[thread overview]
Message-ID: <20261012144603.288276-1-j.theisen@proxmox.com> (raw)

Goal of this patch series is to update the http_proxy config
across the whole cluster immideately after a config change
and independently of the use of PVE tooling to trigger
a database update.

To allow reuse of the same code this patch series factors out
the relevant function inside the APT part of the API and reuses
the function on change of the http_proxy variable in the Cluster API.

This version also moves from trying to update the local file across
all nodes after a change to updating one file in the pmxcfs and
pointing all nodes to that file via a symlink.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=8031

Thanks for the reviews of v2 @e.huhsovitz and @m.sandoval

Changes from v2:
 * added symlink logic to update call
 * adapted update function to only write on change
 * moved update into datacenter.cfg lock phase

Jonas Theisen (3):
  api: apt: factor out writing the APT proxy config
  api: apt: move proxy config to pmxcfs and symlink to it
  fix #8031: api: cluster options: update APT proxy config on change

 PVE/API2/APT.pm     | 48 ++++++++++++++++++++++++++++++++++++---------
 PVE/API2/Cluster.pm | 12 ++++++++++++
 2 files changed, 51 insertions(+), 9 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-10-12 14:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 14:45 Jonas Theisen [this message]
2026-10-12 14:45 ` [PATCH pve-mamager v3 1/3] api: apt: factor out writing the APT proxy config Jonas Theisen
2026-10-12 14:45 ` [PATCH pve-mamager v3 2/3] api: apt: move proxy config to pmxcfs and symlink to it Jonas Theisen
2026-10-12 14:45 ` [PATCH pve-mamager v3 3/3] fix #8031: api: cluster options: update APT proxy config on change Jonas Theisen
2026-10-12 14:58 ` [PATCH pve-mamager v3 0/3] fix #8031: Write APT proxy config on http_proxy change Jonas Theisen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261012144603.288276-1-j.theisen@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal