From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id DAD591FF09B for ; Mon, 12 Oct 2026 16:46:16 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 96B49215FD; Mon, 12 Oct 2026 16:46:13 +0200 (CEST) From: Jonas Theisen To: pve-devel@lists.proxmox.com Subject: [PATCH pve-mamager v3 0/3] fix #8031: Write APT proxy config on http_proxy change Date: Mon, 12 Oct 2026 16:45:33 +0200 Message-ID: <20261012144603.288276-1-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791816366936 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.148 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Y4VHDUY6NBO2RBWG2AXUHEGPFFBW7W3K X-Message-ID-Hash: Y4VHDUY6NBO2RBWG2AXUHEGPFFBW7W3K X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Goal of this patch series is to update the http_proxy config across the whole cluster immideately after a config change and independently of the use of PVE tooling to trigger a database update. To allow reuse of the same code this patch series factors out the relevant function inside the APT part of the API and reuses the function on change of the http_proxy variable in the Cluster API. This version also moves from trying to update the local file across all nodes after a change to updating one file in the pmxcfs and pointing all nodes to that file via a symlink. Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=8031 Thanks for the reviews of v2 @e.huhsovitz and @m.sandoval Changes from v2: * added symlink logic to update call * adapted update function to only write on change * moved update into datacenter.cfg lock phase Jonas Theisen (3): api: apt: factor out writing the APT proxy config api: apt: move proxy config to pmxcfs and symlink to it fix #8031: api: cluster options: update APT proxy config on change PVE/API2/APT.pm | 48 ++++++++++++++++++++++++++++++++++++--------- PVE/API2/Cluster.pm | 12 ++++++++++++ 2 files changed, 51 insertions(+), 9 deletions(-) -- 2.47.3