[PATCH pve-mamager v3 3/3] fix #8031: api: cluster options: update APT proxy config on change

[Jonas Theisen <j.theisen@proxmox.com>]

Changing the http_proxy datacenter option did not update the APT
proxy config until the next package database update. Write it right
away, so APT on all nodes uses the new proxy immediately.

Do so while still holding the datacenter.cfg lock, so concurrent
changes cannot write the APT config in a different order than the
datacenter config.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=8031
Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 PVE/API2/Cluster.pm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
index 4e5efbfd..29820c59 100644
--- a/PVE/API2/Cluster.pm
+++ b/PVE/API2/Cluster.pm
@@ -23,6 +23,7 @@ use PVE::Tools qw(extract_param);
 
 use PVE::API2::ACMEAccount;
 use PVE::API2::ACMEPlugin;
+use PVE::API2::APT;
 use PVE::API2::Backup;
 use PVE::API2::Cluster::BackupInfo;
 use PVE::API2::Cluster::BulkAction;
@@ -842,8 +843,17 @@ __PACKAGE__->register_method({
     code => sub {
         my ($param) = @_;
 
+        my $http_proxy_change = 0;
+
         my $delete = extract_param($param, 'delete');
 
+        if (
+            defined($param->{http_proxy})
+            || (defined($delete) && $delete =~ m/\bhttp_proxy\b/)
+        ) {
+            $http_proxy_change = 1;
+        }
+
         cfs_lock_file(
             'datacenter.cfg',
             undef,
@@ -855,6 +865,8 @@ __PACKAGE__->register_method({
                 delete $conf->{$_} for PVE::Tools::split_list($delete);
 
                 cfs_write_file('datacenter.cfg', $conf);
+
+                PVE::API2::APT::update_apt_proxy_config($conf) if $http_proxy_change;
             },
         );
         die $@ if $@;
-- 
2.47.3