public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Michal Fox <me@dualfroz.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 1/2] fix #6516: api: backup jobs: limit the job ID length on creation
Date: Sat, 26 Sep 2026 07:29:32 +0000	[thread overview]
Message-ID: <20260926072933.7-2-me@dualfroz.com> (raw)
In-Reply-To: <20260926072933.7-1-me@dualfroz.com>

All backup job API calls that take an existing job ID use the
'pve-backup-jobid' option, which is limited to 50 characters. The
create call uses its own 'id' parameter without that limit, so a longer
ID can be created, but the job can then neither be read, updated nor
deleted through the API or the web UI, and has to be removed from
jobs.cfg by hand.

Apply the same limit when creating the job.

Signed-off-by: Michal Fox <me@dualfroz.com>
---
 PVE/API2/Backup.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
index 3bd85593..a890c1fa 100644
--- a/PVE/API2/Backup.pm
+++ b/PVE/API2/Backup.pm
@@ -259,6 +259,7 @@ __PACKAGE__->register_method({
                 type => 'string',
                 description => "Job ID (will be autogenerated).",
                 format => 'pve-configid',
+                maxLength => 50,
                 optional => 1, # FIXME: make required on 8.0
             },
             schedule => {
-- 
2.43.0




  reply	other threads:[~2026-09-28  7:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26  7:29 [PATCH manager 0/2] fix #6516: limit the backup job ID length on creation Michal Fox
2026-09-26  7:29 ` Michal Fox [this message]
2026-09-26  7:29 ` [PATCH manager 2/2] fix #6516: ui: backup job: limit the job ID length Michal Fox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260926072933.7-2-me@dualfroz.com \
    --to=me@dualfroz.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal