public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Michal Fox <me@dualfroz.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 0/2] fix #6516: limit the backup job ID length on creation
Date: Sat, 26 Sep 2026 07:29:31 +0000	[thread overview]
Message-ID: <20260926072933.7-1-me@dualfroz.com> (raw)

creating a backup job did not check the 50 character limit that every
other backup job API call enforces, so a job with a longer ID could be
created but then neither be edited nor removed (#6516). the first patch
adds the limit to the create call, the second one marks a longer ID as
invalid in the edit window already.

tested by validating the create parameters against the API schema in a
container: 51 characters are now rejected, 50 still work, and in a
browser with the built pvemanagerlib.js the Job ID field shows the
maximum length error.

Michal Fox (2):
  fix #6516: api: backup jobs: limit the job ID length on creation
  fix #6516: ui: backup job: limit the job ID length

 PVE/API2/Backup.pm                          | 1 +
 www/manager6/panel/BackupAdvancedOptions.js | 1 +
 2 files changed, 2 insertions(+)

-- 
2.43.0




             reply	other threads:[~2026-09-28  7:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26  7:29 Michal Fox [this message]
2026-09-26  7:29 ` [PATCH manager 1/2] fix #6516: api: backup jobs: limit the job ID length on creation Michal Fox
2026-09-26  7:29 ` [PATCH manager 2/2] fix #6516: ui: backup job: limit the job ID length Michal Fox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260926072933.7-1-me@dualfroz.com \
    --to=me@dualfroz.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal