From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 467F91FF09B for ; Mon, 28 Sep 2026 09:17:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BB22D2195A; Mon, 28 Sep 2026 09:15:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dualfroz.com; s=dkim; t=1790407779; h=from:subject:date:message-id:to:mime-version: content-transfer-encoding; bh=ot2XMS62uLKP4383C727MRwmN0NcExjWC51KDknYmY8=; b=qNyNLeeBDmw2dQGnXgdm8Owga61/+LlDPPcZRtlvQwGFadynD0qdRo2A5wukBRtutVmFto 3urW9wdUKdW3GIeygPRJZ0uKFqTc5JIyfUCtomPUe6TsPFWgjMUqpctzjIvMysFt0WvmBM DYQzOhdcjj0Lp37i6/w2zRN0d002InRwraIcq99bHhewm8Y10yV/u3QDGjR5moQ0R0MSEc YBuun8ca5Z22dAsiZgoU47zeIQEvtcMEBiwPK/4CQG0Mpj6h4YsSnXfv0UkvWDQAgZTzIz xtb65iPF3/XgHade4R/5NqCD3R2Krdoz6DL0Kv5Dw6lbadnVotU+YPreG8nw6Q== From: Michal Fox To: pve-devel@lists.proxmox.com Subject: [PATCH manager 0/2] fix #6516: limit the backup job ID length on creation Date: Sat, 26 Sep 2026 07:29:31 +0000 Message-ID: <20260926072933.7-1-me@dualfroz.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.372 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: me@dualfroz.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: JV6VISSRSTBQ5SREB64BMI2DFSXYRCKQ X-Message-ID-Hash: JV6VISSRSTBQ5SREB64BMI2DFSXYRCKQ X-Mailman-Approved-At: Mon, 28 Sep 2026 09:14:43 +0200 X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: creating a backup job did not check the 50 character limit that every other backup job API call enforces, so a job with a longer ID could be created but then neither be edited nor removed (#6516). the first patch adds the limit to the create call, the second one marks a longer ID as invalid in the edit window already. tested by validating the create parameters against the API schema in a container: 51 characters are now rejected, 50 still work, and in a browser with the built pvemanagerlib.js the Job ID field shows the maximum length error. Michal Fox (2): fix #6516: api: backup jobs: limit the job ID length on creation fix #6516: ui: backup job: limit the job ID length PVE/API2/Backup.pm | 1 + www/manager6/panel/BackupAdvancedOptions.js | 1 + 2 files changed, 2 insertions(+) -- 2.43.0