From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 323A21FF09B for ; Mon, 28 Sep 2026 09:17:27 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7847421996; Mon, 28 Sep 2026 09:15:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dualfroz.com; s=dkim; t=1790407780; h=from:subject:date:message-id:to:mime-version: content-transfer-encoding:in-reply-to:references; bh=K7RIg2yX7M/BPyKsPrckuGCWX7sUlMttYpcky79d4yw=; b=mBrlX0HratyENUwdhmDm9cfiRcvRZcPDyBQ6VDWzmjjt6nuH3JmpqLgpFRJZlUzb3uUxaL KIeQXFSxjIwDwa/gDxI6cJ8p8nuy4/lPhCOk9LLpvJXeAc2FCQq8ASsuXCFID8s61OvsUC qukkz3XiLSzC0PGULjy6qMRMKxAAHNU8JPJbbsvVKutvpYi8go1JTUuSfqVI8yMnV6JAm5 M+rI/LouJ2PPjo83iArHqdcGx24yDJTY/onpszvIWnRm/MKMZ68DI9nKB7pXQl3Ygo8iLz DOwOfQ+G1zOS+FrP/PAXgnof71wh+r1E81I0ONOoitLMN7CtNxtW7h2M5dP9cw== From: Michal Fox To: pve-devel@lists.proxmox.com Subject: [PATCH manager 1/2] fix #6516: api: backup jobs: limit the job ID length on creation Date: Sat, 26 Sep 2026 07:29:32 +0000 Message-ID: <20260926072933.7-2-me@dualfroz.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260926072933.7-1-me@dualfroz.com> References: <20260926072933.7-1-me@dualfroz.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.323 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: me@dualfroz.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: OECPS2Y3M4UL74HRQEEDKVSGM5QDBS44 X-Message-ID-Hash: OECPS2Y3M4UL74HRQEEDKVSGM5QDBS44 X-Mailman-Approved-At: Mon, 28 Sep 2026 09:14:43 +0200 X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: All backup job API calls that take an existing job ID use the 'pve-backup-jobid' option, which is limited to 50 characters. The create call uses its own 'id' parameter without that limit, so a longer ID can be created, but the job can then neither be read, updated nor deleted through the API or the web UI, and has to be removed from jobs.cfg by hand. Apply the same limit when creating the job. Signed-off-by: Michal Fox --- PVE/API2/Backup.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 3bd85593..a890c1fa 100644 --- a/PVE/API2/Backup.pm +++ b/PVE/API2/Backup.pm @@ -259,6 +259,7 @@ __PACKAGE__->register_method({ type => 'string', description => "Job ID (will be autogenerated).", format => 'pve-configid', + maxLength => 50, optional => 1, # FIXME: make required on 8.0 }, schedule => { -- 2.43.0