public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v5 5/9] code cleanup: pci: rename 'd' variable to 'pci_device'
Date: Wed, 23 Sep 2026 09:04:58 +0200	[thread overview]
Message-ID: <20260923070522.434715-6-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260923070522.434715-1-d.csapak@proxmox.com>

to make it a bit cleare what it is.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
new in v5
 src/PVE/QemuServer/PCI.pm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/PVE/QemuServer/PCI.pm b/src/PVE/QemuServer/PCI.pm
index 548c4720..5cb6e91c 100644
--- a/src/PVE/QemuServer/PCI.pm
+++ b/src/PVE/QemuServer/PCI.pm
@@ -729,13 +729,13 @@ sub prepare_pci_devices {
     reserve_pci_usage($pci_reserve_list, $vmid, $start_timeout);
 
     for my $id (sort keys %$pci_devices) {
-        my $d = $pci_devices->{$id};
+        my $pci_device = $pci_devices->{$id};
         my ($index) = ($id =~ m/^hostpci(\d+)$/);
 
         my $chosen_mdev;
-        for my $dev ($d->{ids}->@*) {
-            my $info = eval { prepare_pci_device($vmid, $dev->{id}, $index, $d) };
-            if ($d->{mdev} || $d->{nvidia}) {
+        for my $dev ($pci_device->{ids}->@*) {
+            my $info = eval { prepare_pci_device($vmid, $dev->{id}, $index, $pci_device) };
+            if ($pci_device->{mdev} || $pci_device->{nvidia}) {
                 warn $@ if $@;
                 $chosen_mdev = $info;
                 last if $chosen_mdev; # if successful, we're done
@@ -744,7 +744,7 @@ sub prepare_pci_devices {
             }
         }
 
-        next if !$d->{mdev} && !$d->{nvidia};
+        next if !$pci_device->{mdev} && !$pci_device->{nvidia};
         die "could not create mediated device\n" if !defined($chosen_mdev);
 
         # nvidia vgpu needs a uuid as qemu parameter
-- 
2.47.3





  parent reply	other threads:[~2026-09-23  7:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23  7:04 [PATCH docs/guest-common/qemu-server v5 0/9] add new pci passthrough specific hookscript phase Dominik Csapak
2026-09-23  7:04 ` [PATCH guest-common v5 1/9] helpers: exec hookscript: add optional parameters Dominik Csapak
2026-09-23  7:04 ` [PATCH qemu-server v5 2/9] pci: mdev preparation: always generate local uuid first Dominik Csapak
2026-09-23  7:04 ` [PATCH qemu-server v5 3/9] pci: nvidia vgpu: correct wrong comment about uuid Dominik Csapak
2026-09-23  7:04 ` [PATCH qemu-server v5 4/9] pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module Dominik Csapak
2026-09-23  7:04 ` Dominik Csapak [this message]
2026-09-23  7:04 ` [PATCH qemu-server v5 6/9] pci: preparation: mdev: only generate uuid once Dominik Csapak
2026-09-23  7:05 ` [PATCH qemu-server v5 7/9] pci: call hookscript for each prepared pci device Dominik Csapak
2026-09-23  7:05 ` [PATCH docs v5 8/9] examples: add new hookscript phase to example hookscript Dominik Csapak
2026-09-23  7:05 ` [PATCH docs v5 9/9] examples: downgrade 'die' in example hookscript to 'warn' Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923070522.434715-6-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal