From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH docs v5 9/9] examples: downgrade 'die' in example hookscript to 'warn'
Date: Wed, 23 Sep 2026 09:05:02 +0200 [thread overview]
Message-ID: <20260923070522.434715-10-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260923070522.434715-1-d.csapak@proxmox.com>
So when users copy and modify the hookscript, they only get a warning
when new phases are added.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
new in v5
examples/guest-example-hookscript.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/guest-example-hookscript.pl b/examples/guest-example-hookscript.pl
index 02e7e7d..853304f 100755
--- a/examples/guest-example-hookscript.pl
+++ b/examples/guest-example-hookscript.pl
@@ -84,7 +84,7 @@ if ($phase eq 'pre-start') {
print "$vmid stopped. Doing cleanup.\n";
} else {
- die "got unknown phase '$phase'\n";
+ warn "got unknown phase '$phase'\n";
}
exit(0);
--
2.47.3
prev parent reply other threads:[~2026-09-23 7:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 7:04 [PATCH docs/guest-common/qemu-server v5 0/9] add new pci passthrough specific hookscript phase Dominik Csapak
2026-09-23 7:04 ` [PATCH guest-common v5 1/9] helpers: exec hookscript: add optional parameters Dominik Csapak
2026-09-23 7:04 ` [PATCH qemu-server v5 2/9] pci: mdev preparation: always generate local uuid first Dominik Csapak
2026-09-23 7:04 ` [PATCH qemu-server v5 3/9] pci: nvidia vgpu: correct wrong comment about uuid Dominik Csapak
2026-09-23 7:04 ` [PATCH qemu-server v5 4/9] pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module Dominik Csapak
2026-09-23 7:04 ` [PATCH qemu-server v5 5/9] code cleanup: pci: rename 'd' variable to 'pci_device' Dominik Csapak
2026-09-23 7:04 ` [PATCH qemu-server v5 6/9] pci: preparation: mdev: only generate uuid once Dominik Csapak
2026-09-23 7:05 ` [PATCH qemu-server v5 7/9] pci: call hookscript for each prepared pci device Dominik Csapak
2026-09-23 7:05 ` [PATCH docs v5 8/9] examples: add new hookscript phase to example hookscript Dominik Csapak
2026-09-23 7:05 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923070522.434715-10-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox