From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 371641FF0AB for ; Wed, 23 Sep 2026 09:06:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9337C21655; Wed, 23 Sep 2026 09:05:31 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v5 5/9] code cleanup: pci: rename 'd' variable to 'pci_device' Date: Wed, 23 Sep 2026 09:04:58 +0200 Message-ID: <20260923070522.434715-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260923070522.434715-1-d.csapak@proxmox.com> References: <20260923070522.434715-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.552 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_MAILER 2 Automated Mailer Tag Left in Email RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VHIDAHVEAXJMGT7SUMFERJ5VGDSJYWUF X-Message-ID-Hash: VHIDAHVEAXJMGT7SUMFERJ5VGDSJYWUF X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: to make it a bit cleare what it is. Signed-off-by: Dominik Csapak --- new in v5 src/PVE/QemuServer/PCI.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/QemuServer/PCI.pm b/src/PVE/QemuServer/PCI.pm index 548c4720..5cb6e91c 100644 --- a/src/PVE/QemuServer/PCI.pm +++ b/src/PVE/QemuServer/PCI.pm @@ -729,13 +729,13 @@ sub prepare_pci_devices { reserve_pci_usage($pci_reserve_list, $vmid, $start_timeout); for my $id (sort keys %$pci_devices) { - my $d = $pci_devices->{$id}; + my $pci_device = $pci_devices->{$id}; my ($index) = ($id =~ m/^hostpci(\d+)$/); my $chosen_mdev; - for my $dev ($d->{ids}->@*) { - my $info = eval { prepare_pci_device($vmid, $dev->{id}, $index, $d) }; - if ($d->{mdev} || $d->{nvidia}) { + for my $dev ($pci_device->{ids}->@*) { + my $info = eval { prepare_pci_device($vmid, $dev->{id}, $index, $pci_device) }; + if ($pci_device->{mdev} || $pci_device->{nvidia}) { warn $@ if $@; $chosen_mdev = $info; last if $chosen_mdev; # if successful, we're done @@ -744,7 +744,7 @@ sub prepare_pci_devices { } } - next if !$d->{mdev} && !$d->{nvidia}; + next if !$pci_device->{mdev} && !$pci_device->{nvidia}; die "could not create mediated device\n" if !defined($chosen_mdev); # nvidia vgpu needs a uuid as qemu parameter -- 2.47.3