[PATCH pve-storage 2/2] esxi: guard against zero 'cpuid.coresPerSocket'

[Nicolas Frey <n.frey@proxmox.com>]

ESXi sets 'cpuid.coresPerSocket' to 0 when the CPU topology is set to
'Assigned at power on'. cpu_info() divided by it unconditionally, so
such a VM aborted the import with "Illegal division by zero".

Fall back to one core per socket, matching the default already used
for a missing key, and log a warning so the resulting topology can be
checked.

Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---

Notes:
    The warning could also be emitted in case 'cpuid.coresPerSocket' is not
    present at all (right above)

 src/PVE/Storage/ESXiPlugin.pm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index 19f23bb..4d27bff 100644
--- a/src/PVE/Storage/ESXiPlugin.pm
+++ b/src/PVE/Storage/ESXiPlugin.pm
@@ -746,6 +746,8 @@ use strict;
 use warnings;
 use feature 'fc';
 
+use PVE::RESTEnvironment qw(log_warn);
+
 # FIXME: see if vmx files can actually have escape sequences in their quoted values?
 my sub unquote : prototype($) {
     my ($value) = @_;
@@ -890,6 +892,12 @@ sub cpu_info {
     my ($self) = @_;
 
     my $cps = int($self->{'cpuid.coresPerSocket'} // 1);
+    # ESXi reports 0 when the CPU topology is 'Assigned at power on'.
+    if ($cps == 0) {
+        log_warn("'cpuid.coresPerSocket' is set to 0, assuming 1 core per socket\n");
+        $cps = 1;
+    }
+
     my $max = int($self->{numvcpus} // $cps);
 
     return ($cps, ($max / $cps));
-- 
2.47.3