[PATCH pve-manager 1/2] fix #6202: ui: guest import: warn if sockets exceed target node

[Nicolas Frey <n.frey@proxmox.com>]

ESXi and PVE model CPU topology differently, so the socket count
taken from the source VM can exceed the number of sockets the target
node actually has. The import then succeeds but yields a guest whose
topology does not match the hardware.

Query the node status and show a hint next to the socket field when
the configured count is higher, suggesting cores instead.

Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
 www/manager6/window/GuestImport.js | 33 ++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index 1013fe14..896cd9ac 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -310,6 +310,7 @@ Ext.define('PVE.window.GuestImport', {
         data: {
             coreCount: 1,
             socketCount: 1,
+            nodeSockets: 0,
             liveImport: false,
             os: 'l26',
             maxCdDrives: false,
@@ -320,6 +321,20 @@ Ext.define('PVE.window.GuestImport', {
 
         formulas: {
             totalCoreCount: (get) => get('socketCount') * get('coreCount'),
+            // ESXi and PVE model CPU topology differently, so an imported socket count can
+            // exceed what the target node physically has.
+            socketCountHint: (get) => {
+                let nodeSockets = get('nodeSockets');
+                if (!nodeSockets || get('socketCount') <= nodeSockets) {
+                    return '';
+                }
+                return Ext.String.format(
+                    gettext(
+                        'Target node has only {0} CPU socket(s), consider using cores instead.',
+                    ),
+                    nodeSockets,
+                );
+            },
             hideWarnings: (get) => get('warnings').length === 0,
             warningsText: (get) =>
                 '<ul style="margin: 0; padding-left: 20px;">' +
@@ -500,6 +515,15 @@ Ext.define('PVE.window.GuestImport', {
                                 value: '{socketCount}',
                             },
                         },
+                        {
+                            xtype: 'displayfield',
+                            userCls: 'pmx-hint',
+                            hidden: true,
+                            bind: {
+                                value: '{socketCountHint}',
+                                hidden: '{!socketCountHint}',
+                            },
+                        },
                         {
                             xtype: 'proxmoxintegerfield',
                             fieldLabel: gettext('Cores'),
@@ -1010,6 +1034,15 @@ Ext.define('PVE.window.GuestImport', {
         me.lookup('defaultBridge').setNodename(me.nodename);
         me.lookup('extractionStorage').setNodename(me.nodename);
 
+        Proxmox.Utils.API2Request({
+            url: `/nodes/${me.nodename}/status`,
+            method: 'GET',
+            autoErrorAlert: false,
+            success: function (response) {
+                me.getViewModel().set('nodeSockets', response.result.data.cpuinfo?.sockets ?? 0);
+            },
+        });
+
         let renderWarning = (w) => {
             const warningsCatalogue = {
                 'cdrom-image-ignored': gettext(
-- 
2.47.3