public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Nicolas Frey <n.frey@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager/storage 0/2] fix #6202: warn if sockets exceed target node
Date: Tue, 22 Sep 2026 14:33:23 +0200	[thread overview]
Message-ID: <20260922123325.498271-1-n.frey@proxmox.com> (raw)

and guard against division by zero in the import.

The latter came up in enterprise support, which is only tangentially
related to the original issue (but got me into fixing this issue in
the first place).

Tested using an ESXi VM with the entry 'cpuid.coresPerSocket'
manually set to '0', which can normally only happen when it is set to
"Assigned at power on" [0], i.e. the number of cores per socket is
"optimally selected" by ESXi.

Feedback on what to use as the nodeSocket heuristic would be great,
the initial bug report suggests the # of sockets on the node, but if
e.g. NUMA is enabled, then the # of CPU cores is the actual max for VM
sockets. Or do we want to generally warn about the differences between
how PVE and ESXi model CPU topology, regardless of the node's sockets?

[0] https://techdocs.broadcom.com/us/en/vmware-cis/vsphere/vsphere/9-0/vsphere-resource-management/using-numa-systems-with-esxi/virtual-numa-controls.html

pve-manager:

Nicolas Frey (1):
  fix #6202: ui: guest import: warn if sockets exceed target node

 www/manager6/window/GuestImport.js | 33 ++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)


pve-storage:

Nicolas Frey (1):
  esxi: guard against zero 'cpuid.coresPerSocket'

 src/PVE/Storage/ESXiPlugin.pm | 8 ++++++++
 1 file changed, 8 insertions(+)


Summary over all repositories:
  2 files changed, 41 insertions(+), 0 deletions(-)

--
Generated by murpp 0.12.1



             reply	other threads:[~2026-09-22 12:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 12:33 Nicolas Frey [this message]
2026-09-22 12:33 ` [PATCH pve-manager 1/2] fix #6202: ui: guest import: warn if sockets exceed target node Nicolas Frey
2026-09-22 12:33 ` [PATCH pve-storage 2/2] esxi: guard against zero 'cpuid.coresPerSocket' Nicolas Frey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922123325.498271-1-n.frey@proxmox.com \
    --to=n.frey@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal