public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH docs 0/2] cephx-migration: Replace consumer with client
@ 2026-09-08 11:37 Maximiliano Sandoval
  2026-09-08 11:37 ` [PATCH docs 1/2] " Maximiliano Sandoval
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Maximiliano Sandoval @ 2026-09-08 11:37 UTC (permalink / raw)
  To: pve-devel

And add a link to the CVE.

See commits. 

Maximiliano Sandoval (2):
  cephx-migration: Replace consumer with client
  cephx-migration: Add link to CVE-2025-30156

 pveceph.adoc | 44 ++++++++++++++++++++++----------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

-- 
2.47.3





^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH docs 1/2] cephx-migration: Replace consumer with client
  2026-09-08 11:37 [PATCH docs 0/2] cephx-migration: Replace consumer with client Maximiliano Sandoval
@ 2026-09-08 11:37 ` Maximiliano Sandoval
  2026-09-08 11:47   ` Michael Köppl
  2026-09-08 11:37 ` [PATCH docs 2/2] cephx-migration: Add link to CVE-2025-30156 Maximiliano Sandoval
  2026-09-08 15:45 ` superseded: [PATCH docs 0/2] cephx-migration: Replace consumer with client Maximiliano Sandoval
  2 siblings, 1 reply; 6+ messages in thread
From: Maximiliano Sandoval @ 2026-09-08 11:37 UTC (permalink / raw)
  To: pve-devel

The later term is used more often in the Proxmox VE documentation and upstream
[1]. The Consumer row is removed from the table to avoid being redudant after
replacing it with Client.

[1] https://docs.ceph.com/en/latest/dev/cephx/

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 pveceph.adoc | 41 ++++++++++++++++++++---------------------
 1 file changed, 20 insertions(+), 21 deletions(-)

diff --git a/pveceph.adoc b/pveceph.adoc
index c9832ec..9664289 100644
--- a/pveceph.adoc
+++ b/pveceph.adoc
@@ -1407,30 +1407,29 @@ automatically.
 [[pveceph_cipher_support]]
 .Check compatibility
 Several workloads can share one Ceph user. Migrate its key only when every
-consumer supports `aes256k`, including disconnected and external clients.
+client supports `aes256k`, including disconnected and external clients.
 Ceph programs from the updated {pve} packages support it; kernel clients
 require a *running* kernel version 7.0 or newer.
 
 [cols="2,3",options="header"]
 |===
-|Consumer |Client implementation
 |Virtual machine with RBD disks |Userspace, unless `krbd` is enabled.
 |Container on RBD |Always the kernel client.
 |CephFS mount |Kernel, unless `fuse` is enabled.
 |===
 
-Check external systems too. If any affected consumer is incompatible or
+Check external systems too. If any affected client is incompatible or
 unknown, leave its user's key unchanged and postpone this step.
 
 .Stage the keys
 Use `--rotate-all-storage-keys` for the dedicated users of managed local RBD
 and CephFS storages, together with `--rotate-admin-key` for `client.admin`,
 which the command line and storages without their own user share. Every
-consumer of these users is affected; storages of external clusters are
+client of these users is affected; storages of external clusters are
 excluded.
 
 The helper stages each new key and writes it to the managed keyring and secret
-files. Both keys remain valid until confirmation, allowing consumers to refresh
+files. Both keys remain valid until confirmation, allowing clients to refresh
 before the old key is retired. If a monitor cannot keep both keys valid, the
 helper refuses staging and names the monitor to update or restart.
 
@@ -1454,8 +1453,8 @@ While a key is staged, do not add or downgrade monitors or change that user's
 keys with other tools. Its `AUTH_INSECURE_CLIENT_KEY_TYPE` warning remains
 until confirmation makes the new key current and invalidates the old one.
 
-[[pveceph_cephx_refresh_consumers]]
-.Refresh consumers
+[[pveceph_cephx_refresh_clients]]
+.Refresh Clients
 * Live-migrate affected virtual machines in the web interface, or stop and
   start them. A guest reboot is not enough.
 * Stop and start affected containers and other RBD clients.
@@ -1468,8 +1467,8 @@ until confirmation makes the new key current and invalidates the old one.
   xref:pveceph_cephx_external_copies[managed key files], then restart or remount
   those clients.
 
-The helper reports sessions that may still hold an old key. Consumer names
-are hints, not a complete workload inventory; check disconnected consumers
+The helper reports sessions that may still hold an old key. Client names
+are hints, not a complete workload inventory; check disconnected clients
 and external key copies yourself.
 
 [[pveceph_cephx_finish]]
@@ -1478,7 +1477,7 @@ and external key copies yourself.
 
 Run a final dry run to check for remaining old-key sessions. It offers a
 confirmation command when its observed checks pass, but cannot verify
-disconnected consumers or external key copies for you.
+disconnected clients or external key copies for you.
 
 [source,bash]
 ----
@@ -1489,7 +1488,7 @@ WARNING: Clients that still need an old key or cipher cannot authenticate
 after this step. Existing IO can appear to work until a reconnect and then
 fail. Do not use `--force` to bypass a blocker.
 
-After checking disconnected consumers and external copies, run the exact
+After checking disconnected clients and external copies, run the exact
 command the dry run prints. When every rotation is ready and no key needs the
 old cipher, it is:
 
@@ -1509,7 +1508,7 @@ Use `pveceph auth status` for current and pending key ciphers, as
 
 NOTE: `/etc/pve/priv/cephx-key-migration.json` records progress and contains
 secret old keys. Protect it and keep it until the migration is complete and
-every consumer has been refreshed. Deleting it earlier loses the records
+every client has been refreshed. Deleting it earlier loses the records
 needed to resume.
 
 Additional Migration Details
@@ -1551,15 +1550,15 @@ checks this again on every run.
 With `--apply`, `--confirm-all-clients-refreshed` makes every staged key current
 and invalidates its previous key. The initial check refuses the entire batch
 if any open rotation is not ready. The helper then rechecks each key before
-retiring its old credential. If a consumer returns during the batch, completed
+retiring its old credential. If a client returns during the batch, completed
 rotations stay committed and the blocked key stays staged. To confirm ready
 users separately, use `--confirm-clients-refreshed <USER>` with `--apply`.
 
 [[pveceph_cephx_external_copies]]
-Key Copies for External Consumers
-+++++++++++++++++++++++++++++++++
+Key Copies for External Clients
++++++++++++++++++++++++++++++++
 
-For an external consumer of the local cluster, copy the staged credential from
+For an external client of the local cluster, copy the staged credential from
 the managed file for its Ceph user:
 
 * RBD keyring: `/etc/pve/priv/ceph/<STORAGE_ID>.keyring`
@@ -1567,7 +1566,7 @@ the managed file for its Ceph user:
 * Administrative keyring: `/etc/pve/priv/ceph.client.admin.keyring`
 
 Use the credential for that user, not `client.admin` as a substitute. Transfer
-it securely and update every saved copy before refreshing the consumer.
+it securely and update every saved copy before refreshing the client.
 Storage backed by an external cluster is different: the helper never rotates
 that cluster's keys. Follow its administrator's key-rotation procedure.
 
@@ -1583,7 +1582,7 @@ To return a staged user to its current key:
 
 . Run the helper with `--abort-staged-key <USER> --apply`. It restores the
   current key to every managed copy while both credentials remain valid.
-. Refresh all consumers back to that key, including disconnected clients and
+. Refresh all clients back to that key, including disconnected clients and
   external key copies. The helper retries managed CephFS mounts as during
   forward migration.
 . Run the helper with `--confirm-abort-clients-refreshed <USER> --apply` to
@@ -1591,9 +1590,9 @@ To return a staged user to its current key:
   incomplete, a visible session uses the staged key, or its key is unknown.
 
 Ceph 19.2.6-pve4 and 20.2.4-pve4 or newer monitors can identify each session's
-key, allowing consumers on the restored key to stay connected during rollback
+key, allowing clients on the restored key to stay connected during rollback
 confirmation. Upgrade and restart older monitors to use this feature. Without
-key identification, every visible consumer of that user must disconnect before
+key identification, every visible client of that user must disconnect before
 confirmation; upgrading is preferable for a shared user such as `client.admin`.
 
 Emergency Cipher Override
@@ -1632,7 +1631,7 @@ these Proxmox VE details:
   `/etc/pve/priv/ceph.mon.keyring`; never overwrite it.
 * Update an encrypted OSD's lockbox key in both the authentication database and
   its block-device LVM tag. Its temporary keyring is not the persistent copy.
-* Refresh every consumer before invalidating its previous Ceph user key.
+* Refresh every client before invalidating its previous Ceph user key.
 * Rotate `client.admin` last and prepare an independently tested recovery user
   before changing it.
 
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH docs 2/2] cephx-migration: Add link to CVE-2025-30156
  2026-09-08 11:37 [PATCH docs 0/2] cephx-migration: Replace consumer with client Maximiliano Sandoval
  2026-09-08 11:37 ` [PATCH docs 1/2] " Maximiliano Sandoval
@ 2026-09-08 11:37 ` Maximiliano Sandoval
  2026-09-08 11:47   ` Michael Köppl
  2026-09-08 15:45 ` superseded: [PATCH docs 0/2] cephx-migration: Replace consumer with client Maximiliano Sandoval
  2 siblings, 1 reply; 6+ messages in thread
From: Maximiliano Sandoval @ 2026-09-08 11:37 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 pveceph.adoc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pveceph.adoc b/pveceph.adoc
index 9664289..625768f 100644
--- a/pveceph.adoc
+++ b/pveceph.adoc
@@ -1341,7 +1341,8 @@ Why the Health Checks Appear
 Ceph Squid 19.2.6 and Ceph Tentacle 20.2.4 add health checks for keys and
 temporary access credentials that use the older `aes` encryption method. The
 checks can therefore appear directly after an upgrade even if the cluster
-worked without warnings before. The older method is affected by CVE-2025-30156.
+worked without warnings before. The older method is affected by
+https://docs.ceph.com/en/latest/security/CVE-2025-30156['CVE-2025-30156'].
 See the upstream release announcement for background footnote:[Ceph: Squid
 v19.2.6 and Tentacle v20.2.4 released
 https://ceph.io/en/news/blog/2026/v20-2-4-v19-2-6-combo-released/].
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH docs 1/2] cephx-migration: Replace consumer with client
  2026-09-08 11:37 ` [PATCH docs 1/2] " Maximiliano Sandoval
@ 2026-09-08 11:47   ` Michael Köppl
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Köppl @ 2026-09-08 11:47 UTC (permalink / raw)
  To: Maximiliano Sandoval, pve-devel

1 nit inline. Apart from that, consider this:

Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>

On Tue Sep 8, 2026 at 1:37 PM CEST, Maximiliano Sandoval wrote:
> The later term is used more often in the Proxmox VE documentation and upstream
> [1]. The Consumer row is removed from the table to avoid being redudant after

nit: s/redudant/redundant

> replacing it with Client.
>
> [1] https://docs.ceph.com/en/latest/dev/cephx/
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---

[snip]




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH docs 2/2] cephx-migration: Add link to CVE-2025-30156
  2026-09-08 11:37 ` [PATCH docs 2/2] cephx-migration: Add link to CVE-2025-30156 Maximiliano Sandoval
@ 2026-09-08 11:47   ` Michael Köppl
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Köppl @ 2026-09-08 11:47 UTC (permalink / raw)
  To: Maximiliano Sandoval, pve-devel

Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>

On Tue Sep 8, 2026 at 1:37 PM CEST, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  pveceph.adoc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/pveceph.adoc b/pveceph.adoc
> index 9664289..625768f 100644
> --- a/pveceph.adoc
> +++ b/pveceph.adoc
> @@ -1341,7 +1341,8 @@ Why the Health Checks Appear
>  Ceph Squid 19.2.6 and Ceph Tentacle 20.2.4 add health checks for keys and
>  temporary access credentials that use the older `aes` encryption method. The
>  checks can therefore appear directly after an upgrade even if the cluster
> -worked without warnings before. The older method is affected by CVE-2025-30156.
> +worked without warnings before. The older method is affected by
> +https://docs.ceph.com/en/latest/security/CVE-2025-30156['CVE-2025-30156'].
>  See the upstream release announcement for background footnote:[Ceph: Squid
>  v19.2.6 and Tentacle v20.2.4 released
>  https://ceph.io/en/news/blog/2026/v20-2-4-v19-2-6-combo-released/].






^ permalink raw reply	[flat|nested] 6+ messages in thread

* superseded: [PATCH docs 0/2] cephx-migration: Replace consumer with client
  2026-09-08 11:37 [PATCH docs 0/2] cephx-migration: Replace consumer with client Maximiliano Sandoval
  2026-09-08 11:37 ` [PATCH docs 1/2] " Maximiliano Sandoval
  2026-09-08 11:37 ` [PATCH docs 2/2] cephx-migration: Add link to CVE-2025-30156 Maximiliano Sandoval
@ 2026-09-08 15:45 ` Maximiliano Sandoval
  2 siblings, 0 replies; 6+ messages in thread
From: Maximiliano Sandoval @ 2026-09-08 15:45 UTC (permalink / raw)
  To: pve-devel

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

> And add a link to the CVE.
>
> See commits. 
>
> Maximiliano Sandoval (2):
>   cephx-migration: Replace consumer with client
>   cephx-migration: Add link to CVE-2025-30156
>
>  pveceph.adoc | 44 ++++++++++++++++++++++----------------------
>  1 file changed, 22 insertions(+), 22 deletions(-)

Added a couple of (potentially more controversial) commits in a follow-up.

Soft-superseded-by: https://lore.proxmox.com/all/20260908153932.577051-1-m.sandoval@proxmox.com/T/#u

-- 
Maximiliano




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-09-08 15:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-08 11:37 [PATCH docs 0/2] cephx-migration: Replace consumer with client Maximiliano Sandoval
2026-09-08 11:37 ` [PATCH docs 1/2] " Maximiliano Sandoval
2026-09-08 11:47   ` Michael Köppl
2026-09-08 11:37 ` [PATCH docs 2/2] cephx-migration: Add link to CVE-2025-30156 Maximiliano Sandoval
2026-09-08 11:47   ` Michael Köppl
2026-09-08 15:45 ` superseded: [PATCH docs 0/2] cephx-migration: Replace consumer with client Maximiliano Sandoval

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal