[PATCH docs/manager/network v2 0/3] remove ASN number

[PATCH docs/manager/network v2 0/3] remove ASN number

[Cole Hughes]

ASN is the acronym of Autonomous System Number [0], it is therefore
redundant to use "ASN #" or "ASN number". We should only use the
following two forms of abbreviation: ASN(s) or AS number(s).

[0] https://en.wikipedia.org/wiki/Autonomous_system_(Internet)

Changes since v1:
* commit messages: added line breaks at 70 characters
* docs: use "multiple ASNs" instead of "multiple ASN"
* docs: add missing 'a' in fabric section ("use a private ASN")


docs:

Cole Hughes (1):
  sdn: removing ASN number

 pvesdn.adoc | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)


manager:

Cole Hughes (1):
  sdn: removing ASN number

 www/manager6/sdn/controllers/BgpEdit.js  | 2 +-
 www/manager6/sdn/controllers/EvpnEdit.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


network:

Cole Hughes (1):
  sdn: removing ASN number

 src/PVE/Network/SDN/Controllers/Plugin.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Summary over all repositories:
  4 files changed, 13 insertions(+), 13 deletions(-)

-- 
Generated by murpp 0.12.1

[PATCH docs v2 1/3] sdn: removing ASN number

[Cole Hughes]

ASN is the acronym for Autonomous System Number, using "ASN #" or
"ASN number" is redundant.

Signed-off-by: Cole Hughes <c.hughes@proxmox.com>
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
---
changes since version 1:
- Fixed missing pluralization and article
---
 pvesdn.adoc | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/pvesdn.adoc b/pvesdn.adoc
index 3fd3533..c85d86a 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -465,8 +465,8 @@ xref:pvesdn_install_frrouting[install FRRouting].
 
 EVPN controller configuration options:
 
-ASN #:: A unique BGP ASN number. It's highly recommended to use a private ASN
-  number (64512 – 65534, 4200000000 – 4294967294), as otherwise you could end up
+ASN:: A unique BGP ASN. It's highly recommended to use a private ASN
+  (64512 – 65534, 4200000000 – 4294967294), as otherwise you could end up
   breaking global routing by mistake. Every EVPN controller configured on a node
   must have the same ASN configured.
 
@@ -516,7 +516,7 @@ Otherwise, if an EVPN controller is configured, then the ASN from the EVPN
 controller is used - otherwise the ASN from the BGP controller.
 
 The SDN stack utilizes the local-as directive together with the `no-prepend
-replace-as` option in the FRR configuration for handling multiple ASN numbers in
+replace-as` option in the FRR configuration for handling multiple ASNs in
 the configuration. This is the case when the BGP and EVPN controller have
 different ASNs configured and auto mode is disabled.
 
@@ -557,8 +557,8 @@ BGP controller configuration options:
 
 Node:: The node of this BGP controller
 
-ASN #:: A unique BGP ASN number. It's highly recommended to use a private ASN
-  number in the range (64512 - 65534) or (4200000000 - 4294967294), as otherwise
+ASN:: A unique BGP ASN. It's highly recommended to use a private ASN
+  in the range (64512 - 65534) or (4200000000 - 4294967294), as otherwise
   you could break global routing by mistake.
 
 Peer:: A list of peer IP addresses you want to communicate with using the
@@ -1192,8 +1192,8 @@ Options that are available on every node that is part of a fabric:
 Node:: Select the node which will be added to the fabric. Only nodes that are
 currently in the cluster will be shown.
 
-ASN:: BGP Autonomous System Number for this node. It is recommended to use
-private ASN numbers (64512-65534 for 16-bit, 4200000000-4294967294 for 32-bit).
+ASN:: BGP Autonomous System Number for this node. It is recommended to use a
+private ASN (64512-65534 for 16-bit, 4200000000-4294967294 for 32-bit).
 
 IPv4:: A unique IPv4 address for this node, also used as the BGP router-id.
 Required when the fabric has an IPv4 prefix configured; each node in the same
@@ -1772,12 +1772,12 @@ EVPN Setup Example
 The example assumes a cluster with three nodes (node1, node2, node3) with IP
 addresses 192.168.0.1, 192.168.0.2 and 192.168.0.3.
 
-Create an EVPN controller, using a private ASN number and the above node
+Create an EVPN controller, using a private ASN and the above node
 addresses as peers.
 
 ----
 ID: myevpnctl
-ASN#: 65000
+ASN: 65000
 Peers: 192.168.0.1,192.168.0.2,192.168.0.3
 ----
 
-- 
2.50.1 (Apple Git-155)

[PATCH manager v2 2/3] sdn: removing ASN number

[Cole Hughes]

ASN is the acronym for Autonomous System Number, using "ASN #" is
redundant.

Signed-off-by: Cole Hughes <c.hughes@proxmox.com>
---
changes since v1:
- no changes
---
 www/manager6/sdn/controllers/BgpEdit.js  | 2 +-
 www/manager6/sdn/controllers/EvpnEdit.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/sdn/controllers/BgpEdit.js b/www/manager6/sdn/controllers/BgpEdit.js
index 5fa9fcb2..20afd5fb 100644
--- a/www/manager6/sdn/controllers/BgpEdit.js
+++ b/www/manager6/sdn/controllers/BgpEdit.js
@@ -34,7 +34,7 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', {
                 minValue: 1,
                 maxValue: 4294967295,
                 value: 65000,
-                fieldLabel: 'ASN #',
+                fieldLabel: 'ASN',
                 allowBlank: false,
             },
             {
diff --git a/www/manager6/sdn/controllers/EvpnEdit.js b/www/manager6/sdn/controllers/EvpnEdit.js
index 46e4ab73..400f42f1 100644
--- a/www/manager6/sdn/controllers/EvpnEdit.js
+++ b/www/manager6/sdn/controllers/EvpnEdit.js
@@ -21,7 +21,7 @@ Ext.define('PVE.sdn.controllers.EvpnInputPanel', {
                 minValue: 1,
                 maxValue: 4294967295,
                 value: 65000,
-                fieldLabel: 'ASN #',
+                fieldLabel: 'ASN',
                 allowBlank: false,
             },
             {
-- 
2.50.1 (Apple Git-155)

[PATCH network v2 3/3] sdn: removing ASN number

[Cole Hughes]

ASN is the acronym for Autonomous System Number. "ASN number" is
redundant.

Signed-off-by: Cole Hughes <c.hughes@proxmox.com>
---
changes since v1:
- no changes
---
 src/PVE/Network/SDN/Controllers/Plugin.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/Network/SDN/Controllers/Plugin.pm b/src/PVE/Network/SDN/Controllers/Plugin.pm
index 6da3eec..6d6b974 100644
--- a/src/PVE/Network/SDN/Controllers/Plugin.pm
+++ b/src/PVE/Network/SDN/Controllers/Plugin.pm
@@ -159,8 +159,8 @@ needs to always use the EVPN ASN in its router definition to ensure correct
 generation for Route Targets (if not using the autort patch).
 
 The FRR config generation logic utilizes the local-as directive for specifying
-alternate ASN numbers. Since local-as is only applicable for eBGP sessions, the
-internal ASN number always needs to be used for the router definition. So if
+alternate ASNs. Since local-as is only applicable for eBGP sessions, the
+internal ASN always needs to be used for the router definition. So if
 there are no EVPN controllers, but iBGP BGP sessions, utilize the ASN configured
 there.
 
-- 
2.50.1 (Apple Git-155)