From: Dietmar Maurer <dietmar@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC pve-manager 21/27] ui: storage wizard: add ZFS over iSCSI support
Date: Fri, 31 Jul 2026 12:21:50 +0200 [thread overview]
Message-ID: <20260731102156.3947857-22-dietmar@proxmox.com> (raw)
In-Reply-To: <20260731102156.3947857-1-dietmar@proxmox.com>
There is no scan API for this SSH-based storage type, so the wizard
splits the existing single dialog into an appliance connection step,
showing only the fields relevant for the selected iSCSI provider, and
a volume settings step.
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
www/manager6/Makefile | 1 +
www/manager6/storage/wizard/ZFSOverISCSI.js | 162 ++++++++++++++++++++
2 files changed, 163 insertions(+)
create mode 100644 www/manager6/storage/wizard/ZFSOverISCSI.js
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 4a413d56..532d4d55 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -383,6 +383,7 @@ JSSRC= \
storage/wizard/CIFS.js \
storage/wizard/IScsi.js \
storage/wizard/FibreChannel.js \
+ storage/wizard/ZFSOverISCSI.js \
Workspace.js \
# end of JSSRC list
diff --git a/www/manager6/storage/wizard/ZFSOverISCSI.js b/www/manager6/storage/wizard/ZFSOverISCSI.js
new file mode 100644
index 00000000..579720a8
--- /dev/null
+++ b/www/manager6/storage/wizard/ZFSOverISCSI.js
@@ -0,0 +1,162 @@
+Ext.define('PVE.storage.wizard.ZFSOverISCSIAppliance', {
+ extend: 'Proxmox.panel.InputPanel',
+ xtype: 'pveStorageWizardZFSOverISCSIAppliance',
+
+ onlineHelp: 'storage_zfs',
+
+ column1: [
+ {
+ xtype: 'pveiScsiProviderSelector',
+ name: 'iscsiprovider',
+ value: 'comstar',
+ fieldLabel: gettext('iSCSI Provider'),
+ allowBlank: false,
+ listeners: {
+ change: function (f, value) {
+ let vm = this.up('window').getViewModel();
+ vm.set('isLIO', value === 'LIO');
+ vm.set('isComstar', value === 'comstar');
+ vm.set('hasWriteCacheOption', value === 'comstar' || value === 'istgt');
+ },
+ },
+ },
+ {
+ xtype: 'textfield',
+ name: 'portal',
+ fieldLabel: gettext('Portal'),
+ allowBlank: false,
+ },
+ {
+ xtype: 'textfield',
+ name: 'target',
+ fieldLabel: gettext('Target'),
+ allowBlank: false,
+ },
+ ],
+
+ column2: [
+ {
+ xtype: 'textfield',
+ name: 'comstar_tg',
+ fieldLabel: gettext('Target group'),
+ allowBlank: true,
+ bind: {
+ disabled: '{!isComstar}',
+ hidden: '{!isComstar}',
+ },
+ },
+ {
+ xtype: 'textfield',
+ name: 'comstar_hg',
+ fieldLabel: gettext('Host group'),
+ allowBlank: true,
+ bind: {
+ disabled: '{!isComstar}',
+ hidden: '{!isComstar}',
+ },
+ },
+ {
+ xtype: 'textfield',
+ name: 'lio_tpg',
+ fieldLabel: gettext('Target portal group'),
+ allowBlank: false,
+ disabled: true,
+ hidden: true,
+ bind: {
+ disabled: '{!isLIO}',
+ hidden: '{!isLIO}',
+ },
+ },
+ ],
+
+ columnB: [
+ {
+ xtype: 'displayfield',
+ userCls: 'pmx-hint',
+ value: gettext(
+ 'The ZFS appliance is managed over SSH, which requires passwordless root access from all nodes.',
+ ),
+ },
+ ],
+});
+
+Ext.define('PVE.storage.wizard.ZFSOverISCSIVolume', {
+ extend: 'Proxmox.panel.InputPanel',
+ xtype: 'pveStorageWizardZFSOverISCSIVolume',
+
+ onlineHelp: 'storage_zfs',
+
+ onGetValues: function (values) {
+ values.nowritecache = values.writecache ? 0 : 1;
+ delete values.writecache;
+ return values;
+ },
+
+ column1: [
+ {
+ xtype: 'textfield',
+ name: 'pool',
+ fieldLabel: gettext('Pool'),
+ allowBlank: false,
+ },
+ {
+ xtype: 'textfield',
+ name: 'blocksize',
+ value: '4k',
+ fieldLabel: gettext('Block Size'),
+ allowBlank: false,
+ validator: PVE.Utils.validateZfsBlocksize,
+ },
+ ],
+
+ column2: [
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'sparse',
+ checked: false,
+ uncheckedValue: 0,
+ fieldLabel: gettext('Thin provision'),
+ },
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'writecache',
+ checked: true,
+ uncheckedValue: 0,
+ fieldLabel: gettext('Write cache'),
+ bind: {
+ disabled: '{!hasWriteCacheOption}',
+ hidden: '{!hasWriteCacheOption}',
+ },
+ },
+ ],
+});
+
+PVE.storage.wizard.types['zfs-over-iscsi'] = {
+ text: gettext('ZFS over iSCSI'),
+ description: gettext(
+ 'ZFS storage appliance managed over SSH, exporting volumes via iSCSI with snapshot support.',
+ ),
+ group: 'san',
+ apiType: 'zfs',
+ viewModel: {
+ data: {
+ isLIO: false,
+ isComstar: true,
+ hasWriteCacheOption: true,
+ },
+ },
+ steps: () => [
+ {
+ xtype: 'pveStorageWizardZFSOverISCSIAppliance',
+ title: gettext('Appliance'),
+ },
+ {
+ xtype: 'pveStorageWizardZFSOverISCSIVolume',
+ title: gettext('Volume Settings'),
+ },
+ ],
+ settings: {
+ onlineHelp: 'storage_zfs',
+ fixedContent: 'images',
+ },
+};
--
2.47.3
next prev parent reply other threads:[~2026-07-31 10:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 10:21 [RFC pve-storage/proxmox-widget-toolkit/pve-manager 00/27] add guided remote storage setup and SAN visibility Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 01/27] diskmanage: collect disk transport type from lsblk Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 02/27] diskmanage: add helper to list multipath devices Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 03/27] diskmanage: qualify NVMe over fabrics transport Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 04/27] disks: list: add include-remote parameter Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 05/27] diskmanage: include iSCSI session devices in disk enumeration Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 06/27] diskmanage: link multipath member disks to their map device Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 07/27] iscsi: factor out session device map from device list Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 08/27] api: scan: add san-luns method listing SAN LUN candidates Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 09/27] disks: lvm: allow creating volume groups on multipath devices Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 10/27] diskmanage: add helper querying multipath path state Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 11/27] diskmanage: add helper querying NVMe native " Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 12/27] api: scan: san-luns: report " Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 13/27] iscsi plugin: list sessions of all transports and capture transport Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 14/27] api: add node-level iSCSI initiator target and session API Dietmar Maurer
2026-07-31 10:21 ` [RFC proxmox-widget-toolkit 15/27] disk selectors: allow opting into remote devices Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 16/27] ui: storage: allow switching the scan node of the NFS/CIFS scan combos Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 17/27] ui: storage: add guided remote storage wizard with NFS support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 18/27] ui: storage wizard: add SMB/CIFS support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 19/27] ui: storage wizard: add iSCSI support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 20/27] ui: storage wizard: add FC-attached SAN (shared LVM) support Dietmar Maurer
2026-07-31 10:21 ` Dietmar Maurer [this message]
2026-07-31 10:21 ` [RFC pve-manager 22/27] ui: dc: storage: add remote storage wizard entry to the add menu Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 23/27] ui: node: add SAN LUNs panel Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 24/27] ui: san luns: show multipath path state Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 25/27] api: nodes: add iSCSI initiator API endpoint Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 26/27] pvenode: add iscsi commands Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 27/27] ui: san luns: show iSCSI targets and sessions Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731102156.3947857-22-dietmar@proxmox.com \
--to=dietmar@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox