public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC proxmox-widget-toolkit 15/27] disk selectors: allow opting into remote devices
Date: Fri, 31 Jul 2026 12:21:44 +0200	[thread overview]
Message-ID: <20260731102156.3947857-16-dietmar@proxmox.com> (raw)
In-Reply-To: <20260731102156.3947857-1-dietmar@proxmox.com>

Generic disk selectors omit devices attached through known remote
storage transports by default, because selecting them for node-local
storage without an explicit opt-in is risky.

Allow specialized callers to request the full list through the new
includeRemoteDisks option.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
 src/form/DiskSelector.js      | 8 ++++++++
 src/form/MultiDiskSelector.js | 8 ++++++++
 2 files changed, 16 insertions(+)

diff --git a/src/form/DiskSelector.js b/src/form/DiskSelector.js
index c2fb924..ec1f8de 100644
--- a/src/form/DiskSelector.js
+++ b/src/form/DiskSelector.js
@@ -11,6 +11,10 @@ Ext.define('Proxmox.form.DiskSelector', {
     // use include-partitions=1 as a parameter
     includePartitions: false,
 
+    // also list devices attached through a remote storage transport (for
+    // example FC, iSCSI, or NVMe over TCP), which the backend excludes by default
+    includeRemoteDisks: false,
+
     // the property the backend wants for the type ('type' by default)
     typeProperty: 'type',
 
@@ -60,6 +64,10 @@ Ext.define('Proxmox.form.DiskSelector', {
             extraParams['include-partitions'] = 1;
         }
 
+        if (me.includeRemoteDisks) {
+            extraParams['include-remote'] = 1;
+        }
+
         var store = Ext.create('Ext.data.Store', {
             filterOnLoad: true,
             model: 'pmx-disk-list',
diff --git a/src/form/MultiDiskSelector.js b/src/form/MultiDiskSelector.js
index 50e819b..98402bc 100644
--- a/src/form/MultiDiskSelector.js
+++ b/src/form/MultiDiskSelector.js
@@ -27,6 +27,10 @@ Ext.define('Proxmox.form.MultiDiskSelector', {
     // add include-partitions=1 as a request parameter
     includePartitions: false,
 
+    // also list devices attached through a remote storage transport (for
+    // example FC, iSCSI, or NVMe over TCP), which the backend excludes by default
+    includeRemoteDisks: false,
+
     disks: [],
 
     allowBlank: false,
@@ -159,6 +163,10 @@ Ext.define('Proxmox.form.MultiDiskSelector', {
             if (me.includePartitions) {
                 extraParams['include-partitions'] = 1;
             }
+
+            if (me.includeRemoteDisks) {
+                extraParams['include-remote'] = 1;
+            }
         }
 
         me.disks = [];
-- 
2.47.3




  parent reply	other threads:[~2026-07-31 10:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 10:21 [RFC pve-storage/proxmox-widget-toolkit/pve-manager 00/27] add guided remote storage setup and SAN visibility Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 01/27] diskmanage: collect disk transport type from lsblk Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 02/27] diskmanage: add helper to list multipath devices Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 03/27] diskmanage: qualify NVMe over fabrics transport Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 04/27] disks: list: add include-remote parameter Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 05/27] diskmanage: include iSCSI session devices in disk enumeration Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 06/27] diskmanage: link multipath member disks to their map device Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 07/27] iscsi: factor out session device map from device list Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 08/27] api: scan: add san-luns method listing SAN LUN candidates Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 09/27] disks: lvm: allow creating volume groups on multipath devices Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 10/27] diskmanage: add helper querying multipath path state Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 11/27] diskmanage: add helper querying NVMe native " Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 12/27] api: scan: san-luns: report " Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 13/27] iscsi plugin: list sessions of all transports and capture transport Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 14/27] api: add node-level iSCSI initiator target and session API Dietmar Maurer
2026-07-31 10:21 ` Dietmar Maurer [this message]
2026-07-31 10:21 ` [RFC pve-manager 16/27] ui: storage: allow switching the scan node of the NFS/CIFS scan combos Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 17/27] ui: storage: add guided remote storage wizard with NFS support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 18/27] ui: storage wizard: add SMB/CIFS support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 19/27] ui: storage wizard: add iSCSI support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 20/27] ui: storage wizard: add FC-attached SAN (shared LVM) support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 21/27] ui: storage wizard: add ZFS over iSCSI support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 22/27] ui: dc: storage: add remote storage wizard entry to the add menu Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 23/27] ui: node: add SAN LUNs panel Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 24/27] ui: san luns: show multipath path state Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 25/27] api: nodes: add iSCSI initiator API endpoint Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 26/27] pvenode: add iscsi commands Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 27/27] ui: san luns: show iSCSI targets and sessions Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260731102156.3947857-16-dietmar@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal