From: Dietmar Maurer <dietmar@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC pve-manager 18/27] ui: storage wizard: add SMB/CIFS support
Date: Fri, 31 Jul 2026 12:21:47 +0200 [thread overview]
Message-ID: <20260731102156.3947857-19-dietmar@proxmox.com> (raw)
In-Reply-To: <20260731102156.3947857-1-dietmar@proxmox.com>
Reuse the CIFS share scanner from the edit dialog and keep the rarely
needed domain and subdirectory options in the advanced section.
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
www/manager6/Makefile | 1 +
www/manager6/storage/wizard/CIFS.js | 117 ++++++++++++++++++++++++++++
2 files changed, 118 insertions(+)
create mode 100644 www/manager6/storage/wizard/CIFS.js
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 10340b5a..3020ca05 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -380,6 +380,7 @@ JSSRC= \
storage/wizard/Wizard.js \
storage/wizard/CommonSettings.js \
storage/wizard/NFS.js \
+ storage/wizard/CIFS.js \
Workspace.js \
# end of JSSRC list
diff --git a/www/manager6/storage/wizard/CIFS.js b/www/manager6/storage/wizard/CIFS.js
new file mode 100644
index 00000000..d9e5f5cf
--- /dev/null
+++ b/www/manager6/storage/wizard/CIFS.js
@@ -0,0 +1,117 @@
+Ext.define('PVE.storage.wizard.CIFSConnection', {
+ extend: 'Proxmox.panel.InputPanel',
+ xtype: 'pveStorageWizardCIFSConnection',
+
+ onlineHelp: 'storage_cifs',
+
+ onGetValues: function (values) {
+ ['username', 'password', 'domain', 'subdir'].forEach(function (opt) {
+ if (values[opt]?.length === 0) {
+ delete values[opt];
+ }
+ });
+ return values;
+ },
+
+ initComponent: function () {
+ let me = this;
+
+ let shareField = () => me.down('field[name=share]');
+
+ me.column1 = [
+ {
+ xtype: 'textfield',
+ name: 'server',
+ fieldLabel: gettext('Server'),
+ allowBlank: false,
+ listeners: {
+ change: (f, value) => shareField().setServer(value),
+ },
+ },
+ {
+ xtype: 'textfield',
+ name: 'username',
+ fieldLabel: gettext('Username'),
+ emptyText: gettext('Guest user'),
+ allowBlank: true,
+ listeners: {
+ change: (f, value) => shareField().setUsername(value),
+ },
+ },
+ {
+ xtype: 'textfield',
+ inputType: 'password',
+ name: 'password',
+ fieldLabel: gettext('Password'),
+ emptyText: gettext('None'),
+ minLength: 1,
+ allowBlank: true,
+ listeners: {
+ change: (f, value) => shareField().setPassword(value),
+ },
+ },
+ {
+ xtype: 'pveCIFSScan',
+ name: 'share',
+ fieldLabel: 'Share',
+ allowBlank: false,
+ },
+ ];
+
+ me.column2 = [];
+ if (!PVE.Utils.isStandaloneNode()) {
+ me.column2.push({
+ xtype: 'pveStorageScanNodeSelector',
+ listeners: {
+ change: function (f, value) {
+ shareField().setNodeName(value);
+ let wizard = me.up('window');
+ wizard.scanNode = value;
+ wizard.down('field[name=nodes]').setValue(value);
+ },
+ },
+ });
+ }
+
+ me.advancedColumn1 = [
+ {
+ xtype: 'textfield',
+ name: 'domain',
+ fieldLabel: gettext('Domain'),
+ allowBlank: true,
+ listeners: {
+ change: (f, value) => shareField().setDomain(value),
+ },
+ },
+ ];
+
+ me.advancedColumn2 = [
+ {
+ xtype: 'textfield',
+ name: 'subdir',
+ fieldLabel: gettext('Subdirectory'),
+ allowBlank: true,
+ emptyText: gettext('/some/path'),
+ },
+ ];
+
+ me.callParent();
+ },
+});
+
+PVE.storage.wizard.types.cifs = {
+ text: 'SMB/CIFS',
+ description: gettext('Shared folder on a Windows server, NAS or Samba server.'),
+ group: 'nas',
+ apiType: 'cifs',
+ steps: () => [
+ {
+ xtype: 'pveStorageWizardCIFSConnection',
+ title: gettext('Connection'),
+ },
+ ],
+ settings: {
+ onlineHelp: 'storage_cifs',
+ defaultContent: ['images'],
+ },
+};
--
2.47.3
next prev parent reply other threads:[~2026-07-31 10:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 10:21 [RFC pve-storage/proxmox-widget-toolkit/pve-manager 00/27] add guided remote storage setup and SAN visibility Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 01/27] diskmanage: collect disk transport type from lsblk Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 02/27] diskmanage: add helper to list multipath devices Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 03/27] diskmanage: qualify NVMe over fabrics transport Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 04/27] disks: list: add include-remote parameter Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 05/27] diskmanage: include iSCSI session devices in disk enumeration Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 06/27] diskmanage: link multipath member disks to their map device Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 07/27] iscsi: factor out session device map from device list Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 08/27] api: scan: add san-luns method listing SAN LUN candidates Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 09/27] disks: lvm: allow creating volume groups on multipath devices Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 10/27] diskmanage: add helper querying multipath path state Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 11/27] diskmanage: add helper querying NVMe native " Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 12/27] api: scan: san-luns: report " Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 13/27] iscsi plugin: list sessions of all transports and capture transport Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-storage 14/27] api: add node-level iSCSI initiator target and session API Dietmar Maurer
2026-07-31 10:21 ` [RFC proxmox-widget-toolkit 15/27] disk selectors: allow opting into remote devices Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 16/27] ui: storage: allow switching the scan node of the NFS/CIFS scan combos Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 17/27] ui: storage: add guided remote storage wizard with NFS support Dietmar Maurer
2026-07-31 10:21 ` Dietmar Maurer [this message]
2026-07-31 10:21 ` [RFC pve-manager 19/27] ui: storage wizard: add iSCSI support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 20/27] ui: storage wizard: add FC-attached SAN (shared LVM) support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 21/27] ui: storage wizard: add ZFS over iSCSI support Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 22/27] ui: dc: storage: add remote storage wizard entry to the add menu Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 23/27] ui: node: add SAN LUNs panel Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 24/27] ui: san luns: show multipath path state Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 25/27] api: nodes: add iSCSI initiator API endpoint Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 26/27] pvenode: add iscsi commands Dietmar Maurer
2026-07-31 10:21 ` [RFC pve-manager 27/27] ui: san luns: show iSCSI targets and sessions Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731102156.3947857-19-dietmar@proxmox.com \
--to=dietmar@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox