[PATCH qemu-server v2 0/2] qemuserver: fix virtio-gpu not being

[PATCH qemu-server v2 0/2] qemuserver: fix virtio-gpu not being

[Kaiyang Wu]

Replace 'virtio-vga-gl' with 'virtio-gpu-gl' to use the correct variant of
virtio-gpu on aarch64, and fix the detection of libGL and libEGL libraries on
non-x86_64 architectures.

Changes v1 -> v2:
- Use the host architecture to locate the libraries (as suggested by Dominik
  Csapak <d.csapak@proxmox.com>)
- Replace 'virtio-vga-gl' with 'virtio-gpu-gl' on aarch64 to make virtio-gl
  display option available on aarch64

Kaiyang Wu (2):
  qemuserver: make base path of libGL and libEGL libraries
    architecture-aware
  qemuserver: replace virtio-vga-gl with virtio-gpu-gl on aarch64

 src/PVE/QemuServer.pm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

-- 
2.52.0

[PATCH qemu-server v2 1/2] qemuserver: make base path of libGL and libEGL libraries architecture-aware

[Kaiyang Wu]

'print_vga_device' assumed x86_64 library path to look for 'libGL.so.1'
and 'libEGL.so.1', which leads to missing libraries error regardless of
whether 'libgl1' and 'libegl1' were installed or not, on architectures
other than x86_64.

Make base path of the libraries architecture-aware to correctly locate
the libraries on non-x86_64 architectures.

Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
---
 src/PVE/QemuServer.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 191ae549..c11351bb 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -1540,7 +1540,9 @@ sub print_vga_device {
     }
 
     if ($vga->{type} eq 'virtio-gl') {
-        my $base = '/usr/lib/x86_64-linux-gnu/lib';
+        my $host_arch = get_host_arch();
+        my $base = "/usr/lib/${host_arch}-linux-gnu/lib";
+
         die "missing libraries for '$vga->{type}' detected! Please install 'libgl1' and 'libegl1'\n"
             if !-e "${base}EGL.so.1" || !-e "${base}GL.so.1";
 
-- 
2.52.0

[PATCH qemu-server v2 2/2] qemuserver: replace virtio-vga-gl with virtio-gpu-gl on aarch64

[Kaiyang Wu]

Fix the issue of virtio-gpu not being available on aarch64.

QEMU only provides the non-VGA variant of virtio-gpu-gl on aarch64.
Replace VGA variant with non-VGA variant for 'virtio-vga-gl' device,
similar to how we replace 'virtio-vga' with 'virtio-gpu' on aarch64.

Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
---
 src/PVE/QemuServer.pm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index c11351bb..16922dd5 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -1487,8 +1487,12 @@ sub print_vga_device {
     my ($conf, $vga, $arch, $machine_version, $id, $qxlnum, $bridges) = @_;
 
     my $type = $vga_map->{ $vga->{type} };
-    if ($arch eq 'aarch64' && defined($type) && $type eq 'virtio-vga') {
-        $type = 'virtio-gpu';
+    if ($arch eq 'aarch64' && defined($type)) {
+        if ($type eq 'virtio-vga') {
+            $type = 'virtio-gpu';
+        } elsif ($type eq 'virtio-vga-gl') {
+            $type = 'virtio-gpu-gl';
+        }
     }
     my $vgamem_mb = $vga->{memory};
 
-- 
2.52.0

Re: [PATCH qemu-server v2 1/2] qemuserver: make base path of libGL and libEGL libraries architecture-aware

[Dominik Csapak]

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>

On 7/16/26 9:35 AM, Kaiyang Wu wrote:
> 'print_vga_device' assumed x86_64 library path to look for 'libGL.so.1'
> and 'libEGL.so.1', which leads to missing libraries error regardless of
> whether 'libgl1' and 'libegl1' were installed or not, on architectures
> other than x86_64.
> 
> Make base path of the libraries architecture-aware to correctly locate
> the libraries on non-x86_64 architectures.
> 
> Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
> ---
>   src/PVE/QemuServer.pm | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index 191ae549..c11351bb 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -1540,7 +1540,9 @@ sub print_vga_device {
>       }
>   
>       if ($vga->{type} eq 'virtio-gl') {
> -        my $base = '/usr/lib/x86_64-linux-gnu/lib';
> +        my $host_arch = get_host_arch();
> +        my $base = "/usr/lib/${host_arch}-linux-gnu/lib";
> +
>           die "missing libraries for '$vga->{type}' detected! Please install 'libgl1' and 'libegl1'\n"
>               if !-e "${base}EGL.so.1" || !-e "${base}GL.so.1";
>   

Re: [PATCH qemu-server v2 2/2] qemuserver: replace virtio-vga-gl with virtio-gpu-gl on aarch64

[Dominik Csapak]

while this works, I'd probably prefer to expand our vga_map mechanism
to include the arch too.

e.g. having a 'sub map_vga_model($vga, $arch)' or
something like this which internally has maybe a type->device
map per arch? (or one per arch + a common fallback where the
different architectures don't differ)

On 7/16/26 9:36 AM, Kaiyang Wu wrote:
> Fix the issue of virtio-gpu not being available on aarch64.
> 
> QEMU only provides the non-VGA variant of virtio-gpu-gl on aarch64.
> Replace VGA variant with non-VGA variant for 'virtio-vga-gl' device,
> similar to how we replace 'virtio-vga' with 'virtio-gpu' on aarch64.
> 
> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
> ---
>   src/PVE/QemuServer.pm | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index c11351bb..16922dd5 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -1487,8 +1487,12 @@ sub print_vga_device {
>       my ($conf, $vga, $arch, $machine_version, $id, $qxlnum, $bridges) = @_;
>   
>       my $type = $vga_map->{ $vga->{type} };
> -    if ($arch eq 'aarch64' && defined($type) && $type eq 'virtio-vga') {
> -        $type = 'virtio-gpu';
> +    if ($arch eq 'aarch64' && defined($type)) {
> +        if ($type eq 'virtio-vga') {
> +            $type = 'virtio-gpu';
> +        } elsif ($type eq 'virtio-vga-gl') {
> +            $type = 'virtio-gpu-gl';
> +        }
>       }
>       my $vgamem_mb = $vga->{memory};
>