public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Kaiyang Wu <wukaiyang2003@gmail.com>, pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: Re: [PATCH qemu-server v2 2/2] qemuserver: replace virtio-vga-gl with virtio-gpu-gl on aarch64
Date: Thu, 16 Jul 2026 11:32:49 +0200	[thread overview]
Message-ID: <b2fb8ce7-adcb-4a1f-b406-bf3344bcb66a@proxmox.com> (raw)
In-Reply-To: <20260716073544.284241-3-wukaiyang@loongfans.cn>

while this works, I'd probably prefer to expand our vga_map mechanism
to include the arch too.

e.g. having a 'sub map_vga_model($vga, $arch)' or
something like this which internally has maybe a type->device
map per arch? (or one per arch + a common fallback where the
different architectures don't differ)

On 7/16/26 9:36 AM, Kaiyang Wu wrote:
> Fix the issue of virtio-gpu not being available on aarch64.
> 
> QEMU only provides the non-VGA variant of virtio-gpu-gl on aarch64.
> Replace VGA variant with non-VGA variant for 'virtio-vga-gl' device,
> similar to how we replace 'virtio-vga' with 'virtio-gpu' on aarch64.
> 
> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
> ---
>   src/PVE/QemuServer.pm | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index c11351bb..16922dd5 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -1487,8 +1487,12 @@ sub print_vga_device {
>       my ($conf, $vga, $arch, $machine_version, $id, $qxlnum, $bridges) = @_;
>   
>       my $type = $vga_map->{ $vga->{type} };
> -    if ($arch eq 'aarch64' && defined($type) && $type eq 'virtio-vga') {
> -        $type = 'virtio-gpu';
> +    if ($arch eq 'aarch64' && defined($type)) {
> +        if ($type eq 'virtio-vga') {
> +            $type = 'virtio-gpu';
> +        } elsif ($type eq 'virtio-vga-gl') {
> +            $type = 'virtio-gpu-gl';
> +        }
>       }
>       my $vgamem_mb = $vga->{memory};
>   





  reply	other threads:[~2026-07-16  9:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16  7:35 [PATCH qemu-server v2 0/2] qemuserver: fix virtio-gpu not being Kaiyang Wu
2026-07-16  7:35 ` [PATCH qemu-server v2 1/2] qemuserver: make base path of libGL and libEGL libraries architecture-aware Kaiyang Wu
2026-07-16  9:32   ` Dominik Csapak
2026-07-16  7:35 ` [PATCH qemu-server v2 2/2] qemuserver: replace virtio-vga-gl with virtio-gpu-gl on aarch64 Kaiyang Wu
2026-07-16  9:32   ` Dominik Csapak [this message]
2026-07-16 10:47     ` superseded: " Kaiyang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2fb8ce7-adcb-4a1f-b406-bf3344bcb66a@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=wukaiyang2003@gmail.com \
    --cc=wukaiyang@loongfans.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal