public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v10 08/10] fix #3711: make removal of VM possible if store does not exist anymore
Date: Wed,  1 Jul 2026 16:13:37 +0200	[thread overview]
Message-ID: <20260701141339.181276-9-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20260701141339.181276-1-m.koeppl@proxmox.com>

Similar to the handling of storage errors in other parts of
destroy_vm(), an error during the call to PVE::Storage::path() should
not stop the VM from being destroyed. Instead, the user should be warned
and the function should continue.

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Originally-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
 [ MK: log_warn if check fails instead of ignoring error ]
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 src/PVE/QemuServer.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 50fd66a5..b69af937 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -1857,7 +1857,8 @@ sub destroy_vm {
         return if !$volid || $volid =~ m|^/|;
         return if $volids->{$volid};
 
-        my ($path, $owner) = PVE::Storage::path($storecfg, $volid);
+        my ($path, $owner) = eval { PVE::Storage::path($storecfg, $volid) };
+        log_warn("failed to get path and owner of volume '$volid': $@") if $@;
         return if !$path || !$owner || ($owner != $vmid);
 
         $volids->{$volid} = 1;
-- 
2.47.3





  parent reply	other threads:[~2026-07-01 14:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 14:13 [PATCH container/qemu-server v10 00/10] fix #3711 and adapt drive detach/remove behavior Michael Köppl
2026-07-01 14:13 ` [PATCH container v10 01/10] fix #3711: warn about storage errors during mountpoint delete Michael Köppl
2026-07-01 14:13 ` [PATCH container v10 02/10] destroy_lxc, delete_mp_volume: rename $volume to $volid Michael Köppl
2026-07-01 14:13 ` [PATCH container v10 03/10] config: ensure valid volid through parse_volume() Michael Köppl
2026-07-01 14:13 ` [PATCH container v10 04/10] lxc config: add helper for parsing volid and checking if storage exists Michael Köppl
2026-07-01 14:13 ` [PATCH container v10 05/10] allow pending mount point changes if storage is gone Michael Köppl
2026-07-01 14:13 ` [PATCH container v10 06/10] destroy template: add early check for linked clones of volumes Michael Köppl
2026-07-01 14:13 ` [PATCH qemu-server v10 07/10] adapt linked clone check to not die if an error occurs during check Michael Köppl
2026-07-01 14:13 ` Michael Köppl [this message]
2026-07-01 14:13 ` [PATCH qemu-server v10 09/10] destroy_vm: use log_warn for vdisk_free errors for consistency Michael Köppl
2026-07-01 14:13 ` [PATCH qemu-server v10 10/10] display warnings for storage errors or if storage no longer exists Michael Köppl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260701141339.181276-9-m.koeppl@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal