From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH container v10 02/10] destroy_lxc, delete_mp_volume: rename $volume to $volid
Date: Wed, 1 Jul 2026 16:13:31 +0200 [thread overview]
Message-ID: <20260701141339.181276-3-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20260701141339.181276-1-m.koeppl@proxmox.com>
$volid states more clearly that it's a volume ID, avoiding confusion
about the values these variables hold.
No functional change intended.
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
src/PVE/LXC.pm | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index aa5ff315..e76da29f 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1007,16 +1007,16 @@ sub get_primary_ips {
}
sub delete_mountpoint_volume {
- my ($storage_cfg, $vmid, $volume) = @_;
+ my ($storage_cfg, $vmid, $volid) = @_;
- return if PVE::LXC::Config->classify_mountpoint($volume) ne 'volume';
+ return if PVE::LXC::Config->classify_mountpoint($volid) ne 'volume';
- my ($vtype, $name, $owner) = PVE::Storage::parse_volname($storage_cfg, $volume);
+ my ($vtype, $name, $owner) = PVE::Storage::parse_volname($storage_cfg, $volid);
if ($vmid == $owner) {
- PVE::Storage::vdisk_free($storage_cfg, $volume);
+ PVE::Storage::vdisk_free($storage_cfg, $volid);
} else {
- warn "ignore deletion of '$volume', CT $vmid isn't the owner!\n";
+ warn "ignore deletion of '$volid', CT $vmid isn't the owner!\n";
}
}
@@ -1027,13 +1027,13 @@ sub destroy_lxc_container {
my $remove_volume = sub {
my ($ms, $mountpoint) = @_;
- my $volume = $mountpoint->{volume};
+ my $volid = $mountpoint->{volume};
- return if $volids->{$volume};
- $volids->{$volume} = 1;
+ return if $volids->{$volid};
+ $volids->{$volid} = 1;
- eval { delete_mountpoint_volume($storage_cfg, $vmid, $volume); };
- PVE::RESTEnvironment::log_warn("failed to delete mountpoint volume $volume: $@") if $@;
+ eval { delete_mountpoint_volume($storage_cfg, $vmid, $volid); };
+ PVE::RESTEnvironment::log_warn("failed to delete mountpoint volume $volid: $@") if $@;
};
PVE::LXC::Config->foreach_volume_full($conf, { include_unused => 1 }, $remove_volume);
--
2.47.3
next prev parent reply other threads:[~2026-07-01 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 14:13 [PATCH container/qemu-server v10 00/10] fix #3711 and adapt drive detach/remove behavior Michael Köppl
2026-07-01 14:13 ` [PATCH container v10 01/10] fix #3711: warn about storage errors during mountpoint delete Michael Köppl
2026-07-01 14:13 ` Michael Köppl [this message]
2026-07-01 14:13 ` [PATCH container v10 03/10] config: ensure valid volid through parse_volume() Michael Köppl
2026-07-01 14:13 ` [PATCH container v10 04/10] lxc config: add helper for parsing volid and checking if storage exists Michael Köppl
2026-07-01 14:13 ` [PATCH container v10 05/10] allow pending mount point changes if storage is gone Michael Köppl
2026-07-01 14:13 ` [PATCH container v10 06/10] destroy template: add early check for linked clones of volumes Michael Köppl
2026-07-01 14:13 ` [PATCH qemu-server v10 07/10] adapt linked clone check to not die if an error occurs during check Michael Köppl
2026-07-01 14:13 ` [PATCH qemu-server v10 08/10] fix #3711: make removal of VM possible if store does not exist anymore Michael Köppl
2026-07-01 14:13 ` [PATCH qemu-server v10 09/10] destroy_vm: use log_warn for vdisk_free errors for consistency Michael Köppl
2026-07-01 14:13 ` [PATCH qemu-server v10 10/10] display warnings for storage errors or if storage no longer exists Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260701141339.181276-3-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox