[PATCH container v10 04/10] lxc config: add helper for parsing volid and checking if storage exists

["Michael Köppl" <m.koeppl@proxmox.com>]

Add a helper function to avoid repetition across multiple call sites
where a volume id is parsed and functions check for the existence of the
given storage, log a warning and return if it does not exist, and
perform some action otherwise (e.g. adding a disk as unused).

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 src/PVE/LXC/Config.pm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index c8098538..57c93e8a 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -11,6 +11,7 @@ use PVE::DataCenterConfig;
 use PVE::GuestHelpers;
 use PVE::INotify;
 use PVE::JSONSchema qw(get_standard_option);
+use PVE::RESTEnvironment;
 use PVE::Tools;
 
 use PVE::LXC;
@@ -1609,6 +1610,20 @@ sub calculate_memory_constraints {
     return ($memory_max, $memory_high);
 }
 
+# Skip and warn if a volume's backing storage was already removed from the storage config, so
+# guest/volume removal can still proceed.
+sub with_checked_volid {
+    my ($storecfg, $volid, $callback) = @_;
+
+    my ($storeid) = PVE::Storage::parse_volume_id($volid);
+    if (PVE::Storage::storage_config($storecfg, $storeid, 1)) {
+        $callback->();
+    } else {
+        PVE::RESTEnvironment::log_warn(
+            "storage '$storeid' no longer exists, volume '$volid' will be removed");
+    }
+}
+
 my $LXC_FASTPLUG_OPTIONS = {
     'description' => 1,
     'onboot' => 1,
-- 
2.47.3