public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH kernel-helper] proxmox-boot: fix copying memtest86 twice for systemd-boot
@ 2026-06-23 10:29 Stoiko Ivanov
  0 siblings, 0 replies; only message in thread
From: Stoiko Ivanov @ 2026-06-23 10:29 UTC (permalink / raw)
  To: pve-devel

currently this results in having memtest86+.efi present in the ESP's
root as well as in `/EFI/`. I probably overlooked this when adding
the this for grub-booted systems, in addition to systemd-booted
systems.

reported in our community-forum:
https://forum.proxmox.com/threads/184148/

minimally tested by installing this on a system with systemd-boot, and
one with grub (secure-boot), formatting the ESP, running p-b-t init,
rebooting and selecting memtest (worked for systemd-boot, gave an
wrong signature error for secure boot - as expected).

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 src/bin/proxmox-boot-tool | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
index ee04193..d2f06ce 100755
--- a/src/bin/proxmox-boot-tool
+++ b/src/bin/proxmox-boot-tool
@@ -161,11 +161,11 @@ init_bootloader() {
 
 	if [ -d /sys/firmware/efi ]; then
 		memtest=memtest86+x64.efi
-		if [ -f "/boot/$memtest" ]; then
-			echo "Adding $memtest .."
-			cp "/boot/$memtest" "$esp_mp/"
-		fi
 		if [ -n "$mode" ] && [ "$mode" = "grub" ]; then
+			if [ -f "/boot/$memtest" ]; then
+				echo "Adding $memtest .."
+				cp "/boot/$memtest" "$esp_mp/"
+			fi
 			echo "Installing grub x86_64 target.."
 			grub-install.real \
 				--boot-directory "${esp_mp}" \
-- 
2.47.3





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-06-23 10:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-23 10:29 [PATCH kernel-helper] proxmox-boot: fix copying memtest86 twice for systemd-boot Stoiko Ivanov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal