public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH kernel-helper] proxmox-boot: fix copying memtest86 twice for systemd-boot
Date: Tue, 23 Jun 2026 12:29:55 +0200	[thread overview]
Message-ID: <20260623102957.246597-1-s.ivanov@proxmox.com> (raw)

currently this results in having memtest86+.efi present in the ESP's
root as well as in `/EFI/`. I probably overlooked this when adding
the this for grub-booted systems, in addition to systemd-booted
systems.

reported in our community-forum:
https://forum.proxmox.com/threads/184148/

minimally tested by installing this on a system with systemd-boot, and
one with grub (secure-boot), formatting the ESP, running p-b-t init,
rebooting and selecting memtest (worked for systemd-boot, gave an
wrong signature error for secure boot - as expected).

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 src/bin/proxmox-boot-tool | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
index ee04193..d2f06ce 100755
--- a/src/bin/proxmox-boot-tool
+++ b/src/bin/proxmox-boot-tool
@@ -161,11 +161,11 @@ init_bootloader() {
 
 	if [ -d /sys/firmware/efi ]; then
 		memtest=memtest86+x64.efi
-		if [ -f "/boot/$memtest" ]; then
-			echo "Adding $memtest .."
-			cp "/boot/$memtest" "$esp_mp/"
-		fi
 		if [ -n "$mode" ] && [ "$mode" = "grub" ]; then
+			if [ -f "/boot/$memtest" ]; then
+				echo "Adding $memtest .."
+				cp "/boot/$memtest" "$esp_mp/"
+			fi
 			echo "Installing grub x86_64 target.."
 			grub-install.real \
 				--boot-directory "${esp_mp}" \
-- 
2.47.3





                 reply	other threads:[~2026-06-23 10:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260623102957.246597-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal