public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 3/4] remote migration: mtunnel: avoid warning from superfluous call for removing dbus-vmstate
Date: Tue,  9 Jun 2026 16:28:48 +0200	[thread overview]
Message-ID: <20260609142858.1063820-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260609142858.1063820-1-f.ebner@proxmox.com>

Remote migration does not support migrating the conntrack state. And
even if it would, there is no need to do it upon cleanup after errors,
since the state would already be removed in vm_stop_cleanup(). Remove
the superfluous call to avoid a misleading warning:

> failed to retrieve org.qemu.VMState1 owners:
> org.freedesktop.DBus.Error.NameHasNoOwner:
> Could not get owners of name 'org.qemu.VMState1': no such name

Fixes: dc76a590 ("fix #5180: migrate: integrate helper for live-migrating conntrack info")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/API2/Qemu.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 54883f1e..21fe5e26 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -6949,7 +6949,6 @@ __PACKAGE__->register_method({
                             warn $@ if $@;
                         }
 
-                        PVE::QemuServer::DBusVMState::qemu_del_dbus_vmstate($state->{vmid});
                         PVE::QemuServer::destroy_vm($state->{storecfg}, $state->{vmid}, 1);
                     }
 
-- 
2.47.3





  parent reply	other threads:[~2026-06-09 14:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 14:28 [PATCH-SERIES guest-common/qemu-server 0/4] remote migration (and drive mirror) improvements Fiona Ebner
2026-06-09 14:28 ` [PATCH guest-common 1/4] storage tunnel: query disk import: adapt to current signature for file_size_info() Fiona Ebner
2026-06-09 14:28 ` [PATCH guest-common 2/4] storage tunnel: disk migration: bump timeout for image check after import Fiona Ebner
2026-06-09 14:28 ` Fiona Ebner [this message]
2026-06-09 14:28 ` [PATCH qemu-server 4/4] block job: mirror: use correct unit for logging bandwidth limit Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260609142858.1063820-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal