From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 10E9E1FF146 for ; Tue, 09 Jun 2026 16:29:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 73B7B15BCB; Tue, 9 Jun 2026 16:29:08 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 3/4] remote migration: mtunnel: avoid warning from superfluous call for removing dbus-vmstate Date: Tue, 9 Jun 2026 16:28:48 +0200 Message-ID: <20260609142858.1063820-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260609142858.1063820-1-f.ebner@proxmox.com> References: <20260609142858.1063820-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781015296160 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Q5WQGLW73OERY4OBUII7KVZWMITIFL5X X-Message-ID-Hash: Q5WQGLW73OERY4OBUII7KVZWMITIFL5X X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Remote migration does not support migrating the conntrack state. And even if it would, there is no need to do it upon cleanup after errors, since the state would already be removed in vm_stop_cleanup(). Remove the superfluous call to avoid a misleading warning: > failed to retrieve org.qemu.VMState1 owners: > org.freedesktop.DBus.Error.NameHasNoOwner: > Could not get owners of name 'org.qemu.VMState1': no such name Fixes: dc76a590 ("fix #5180: migrate: integrate helper for live-migrating conntrack info") Signed-off-by: Fiona Ebner --- src/PVE/API2/Qemu.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 54883f1e..21fe5e26 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -6949,7 +6949,6 @@ __PACKAGE__->register_method({ warn $@ if $@; } - PVE::QemuServer::DBusVMState::qemu_del_dbus_vmstate($state->{vmid}); PVE::QemuServer::destroy_vm($state->{storecfg}, $state->{vmid}, 1); } -- 2.47.3