public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH guest-common 1/4] storage tunnel: query disk import: adapt to current signature for file_size_info()
Date: Tue,  9 Jun 2026 16:28:46 +0200	[thread overview]
Message-ID: <20260609142858.1063820-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260609142858.1063820-1-f.ebner@proxmox.com>

In pve-storage commit 8364895 ("file size info: allow specifying file
format"), a new parameter for the format was added to the signature of
file_size_info() and while calls without a format parameter are
properly translated and still work (for now), they will trigger a
deprecation warning:

> file_size_info: detected call with legacy parameter order:
> $untrusted before $file_format

Adapt to the new signature to avoid this.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/StorageTunnel.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/StorageTunnel.pm b/src/PVE/StorageTunnel.pm
index 3a9c696..864aa0e 100644
--- a/src/PVE/StorageTunnel.pm
+++ b/src/PVE/StorageTunnel.pm
@@ -297,7 +297,8 @@ sub handle_query_disk_import {
         # check imported image for bad references
         if ($scfg->{path}) {
             my $path = PVE::Storage::path($cfg, $volid);
-            PVE::Storage::file_size_info($path, undef, 1);
+            my $format = (PVE::Storage::parse_volname($cfg, $volid))[6];
+            PVE::Storage::file_size_info($path, undef, $format, 1);
         }
 
         return {
-- 
2.47.3





  reply	other threads:[~2026-06-09 14:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 14:28 [PATCH-SERIES guest-common/qemu-server 0/4] remote migration (and drive mirror) improvements Fiona Ebner
2026-06-09 14:28 ` Fiona Ebner [this message]
2026-06-09 14:28 ` [PATCH guest-common 2/4] storage tunnel: disk migration: bump timeout for image check after import Fiona Ebner
2026-06-09 14:28 ` [PATCH qemu-server 3/4] remote migration: mtunnel: avoid warning from superfluous call for removing dbus-vmstate Fiona Ebner
2026-06-09 14:28 ` [PATCH qemu-server 4/4] block job: mirror: use correct unit for logging bandwidth limit Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260609142858.1063820-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal