From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8C2FA1FF146 for ; Tue, 09 Jun 2026 16:29:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E186015675; Tue, 9 Jun 2026 16:29:04 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH guest-common 1/4] storage tunnel: query disk import: adapt to current signature for file_size_info() Date: Tue, 9 Jun 2026 16:28:46 +0200 Message-ID: <20260609142858.1063820-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260609142858.1063820-1-f.ebner@proxmox.com> References: <20260609142858.1063820-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781015296049 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZURQBKHSUBH3E5GY3O5IF3KPKEPWWSRC X-Message-ID-Hash: ZURQBKHSUBH3E5GY3O5IF3KPKEPWWSRC X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In pve-storage commit 8364895 ("file size info: allow specifying file format"), a new parameter for the format was added to the signature of file_size_info() and while calls without a format parameter are properly translated and still work (for now), they will trigger a deprecation warning: > file_size_info: detected call with legacy parameter order: > $untrusted before $file_format Adapt to the new signature to avoid this. Signed-off-by: Fiona Ebner --- src/PVE/StorageTunnel.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/StorageTunnel.pm b/src/PVE/StorageTunnel.pm index 3a9c696..864aa0e 100644 --- a/src/PVE/StorageTunnel.pm +++ b/src/PVE/StorageTunnel.pm @@ -297,7 +297,8 @@ sub handle_query_disk_import { # check imported image for bad references if ($scfg->{path}) { my $path = PVE::Storage::path($cfg, $volid); - PVE::Storage::file_size_info($path, undef, 1); + my $format = (PVE::Storage::parse_volname($cfg, $volid))[6]; + PVE::Storage::file_size_info($path, undef, $format, 1); } return { -- 2.47.3