public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager] ui: fabrics: skip unsupported ip6 interface properties on submit
@ 2026-06-03 12:49 Lukas Sichert
  2026-06-03 14:22 ` Hannes Laimer
  2026-06-05  8:25 ` superseded: " Lukas Sichert
  0 siblings, 2 replies; 3+ messages in thread
From: Lukas Sichert @ 2026-06-03 12:49 UTC (permalink / raw)
  To: pve-devel; +Cc: Lukas Sichert

The interface grid keeps the node interface data in the record even if
BGP disables the IPv6 column via 'hasIpv6Support=false'. As getValue()
serializes the full record data, BGP interfaces could still submit an
'ip6' property. This results in the error 'format error
interfaces[0].ip6: property is not defined in schema'.

Skip 'ip6' during serialization when IPv6 support is disabled for the
panel.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
 www/manager6/sdn/fabrics/InterfacePanel.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js
index f07e7859..74781267 100644
--- a/www/manager6/sdn/fabrics/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/InterfacePanel.js
@@ -174,7 +174,10 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
                     continue;
                 }
 
-                if (['type', 'isDisabled'].includes(key)) {
+                if (
+                    ['type', 'isDisabled'].includes(key) ||
+                    (key === 'ip6' && !me.hasIpv6Support)
+                ) {
                     continue;
                 }
 
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH manager] ui: fabrics: skip unsupported ip6 interface properties on submit
  2026-06-03 12:49 [PATCH manager] ui: fabrics: skip unsupported ip6 interface properties on submit Lukas Sichert
@ 2026-06-03 14:22 ` Hannes Laimer
  2026-06-05  8:25 ` superseded: " Lukas Sichert
  1 sibling, 0 replies; 3+ messages in thread
From: Hannes Laimer @ 2026-06-03 14:22 UTC (permalink / raw)
  To: Lukas Sichert, pve-devel

On 2026-06-03 14:49, Lukas Sichert wrote:
> The interface grid keeps the node interface data in the record even if
> BGP disables the IPv6 column via 'hasIpv6Support=false'. As getValue()
> serializes the full record data, BGP interfaces could still submit an
> 'ip6' property. This results in the error 'format error
> interfaces[0].ip6: property is not defined in schema'.
> 
> Skip 'ip6' during serialization when IPv6 support is disabled for the
> panel.
> 

the same happens if a IPv4 address is configured for the interface
(in `/etc/network/interfaces`)

we should probably add `hasIpv4Support` to the InterfacePanel, like we
already have it for FabricEdit. then we can also handle the ipv6 col the
same way we do the ipv4 col.. and drop the `initComponent`-thingy in
`bgp/InterfacePanel.js`

> Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
> ---
>  www/manager6/sdn/fabrics/InterfacePanel.js | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js
> index f07e7859..74781267 100644
> --- a/www/manager6/sdn/fabrics/InterfacePanel.js
> +++ b/www/manager6/sdn/fabrics/InterfacePanel.js
> @@ -174,7 +174,10 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
>                      continue;
>                  }
>  
> -                if (['type', 'isDisabled'].includes(key)) {
> +                if (
> +                    ['type', 'isDisabled'].includes(key) ||
> +                    (key === 'ip6' && !me.hasIpv6Support)
> +                ) {
>                      continue;
>                  }
>  





^ permalink raw reply	[flat|nested] 3+ messages in thread

* superseded: [PATCH manager] ui: fabrics: skip unsupported ip6 interface properties on submit
  2026-06-03 12:49 [PATCH manager] ui: fabrics: skip unsupported ip6 interface properties on submit Lukas Sichert
  2026-06-03 14:22 ` Hannes Laimer
@ 2026-06-05  8:25 ` Lukas Sichert
  1 sibling, 0 replies; 3+ messages in thread
From: Lukas Sichert @ 2026-06-05  8:25 UTC (permalink / raw)
  To: Lukas Sichert, pve-devel

superseded-by v2:
https://lore.proxmox.com/all/20260603155521.125175-1-l.sichert@proxmox.com/




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-05  8:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-03 12:49 [PATCH manager] ui: fabrics: skip unsupported ip6 interface properties on submit Lukas Sichert
2026-06-03 14:22 ` Hannes Laimer
2026-06-05  8:25 ` superseded: " Lukas Sichert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal