From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F2A631FF13B for ; Wed, 03 Jun 2026 16:22:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9591D371; Wed, 3 Jun 2026 16:22:16 +0200 (CEST) Message-ID: Date: Wed, 3 Jun 2026 16:22:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH manager] ui: fabrics: skip unsupported ip6 interface properties on submit To: Lukas Sichert , pve-devel@lists.proxmox.com References: <20260603124917.56707-1-l.sichert@proxmox.com> From: Hannes Laimer Content-Language: en-US In-Reply-To: <20260603124917.56707-1-l.sichert@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780496495471 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XMQ6ONV2OXDVBQLWX72LUNJB6FJTTUTC X-Message-ID-Hash: XMQ6ONV2OXDVBQLWX72LUNJB6FJTTUTC X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-06-03 14:49, Lukas Sichert wrote: > The interface grid keeps the node interface data in the record even if > BGP disables the IPv6 column via 'hasIpv6Support=false'. As getValue() > serializes the full record data, BGP interfaces could still submit an > 'ip6' property. This results in the error 'format error > interfaces[0].ip6: property is not defined in schema'. > > Skip 'ip6' during serialization when IPv6 support is disabled for the > panel. > the same happens if a IPv4 address is configured for the interface (in `/etc/network/interfaces`) we should probably add `hasIpv4Support` to the InterfacePanel, like we already have it for FabricEdit. then we can also handle the ipv6 col the same way we do the ipv4 col.. and drop the `initComponent`-thingy in `bgp/InterfacePanel.js` > Signed-off-by: Lukas Sichert > --- > www/manager6/sdn/fabrics/InterfacePanel.js | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js > index f07e7859..74781267 100644 > --- a/www/manager6/sdn/fabrics/InterfacePanel.js > +++ b/www/manager6/sdn/fabrics/InterfacePanel.js > @@ -174,7 +174,10 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', { > continue; > } > > - if (['type', 'isDisabled'].includes(key)) { > + if ( > + ['type', 'isDisabled'].includes(key) || > + (key === 'ip6' && !me.hasIpv6Support) > + ) { > continue; > } >