* [PATCH manager v5] ui: ha: add disarm/re-arm button
@ 2026-05-13 14:12 Dominik Rusovac
2026-05-15 5:04 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Rusovac @ 2026-05-13 14:12 UTC (permalink / raw)
To: pve-devel
The button to disarm HA in either of the resource modes ('freeze' or
'ignore') is disabled as long as HA is disarmed. Analogously, the button
to arm HA is disabled as long as HA is not disarmed.
For feedback, after clicking either of the buttons, icon spins as long as
(dis)arming process has not changed the armed-state of HA.
The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA"
and "Arm HA" are complements. There may be more suitable pairs of icons
though.
Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---
Notes:
changes since v4:
* fix `gettext()` wrapping
www/manager6/ha/Status.js | 125 ++++++++++++++++++++++++++++++++++
www/manager6/ha/StatusView.js | 23 +++++++
2 files changed, 148 insertions(+)
diff --git a/www/manager6/ha/Status.js b/www/manager6/ha/Status.js
index b0b0feb9..26a6c901 100644
--- a/www/manager6/ha/Status.js
+++ b/www/manager6/ha/Status.js
@@ -8,6 +8,114 @@ Ext.define('PVE.ha.Status', {
align: 'stretch',
},
+ viewModel: {
+ data: {
+ haDisarmed: false,
+ },
+ },
+
+ controller: {
+ xclass: 'Ext.app.ViewController',
+
+ handleDisarmButton: function (menuItem) {
+ let me = this;
+ let view = me.getView();
+
+ let warn = Ext.String.format(
+ gettext("Are you sure you want to disarm HA with resource mode '{0}'?"),
+ menuItem.text,
+ );
+
+ let details = gettext(
+ 'While disarmed, HA does not protect your services. Failures during this period are not automatically recovered.',
+ );
+
+ Ext.Msg.confirm(
+ gettext('Confirm'),
+ warn + '<br><br>' + menuItem.details + '<br><br>' + details,
+ function (btn) {
+ if (btn !== 'yes') {
+ return;
+ }
+ Proxmox.Utils.API2Request({
+ url: '/cluster/ha/status/disarm-ha',
+ params: { 'resource-mode': menuItem.mode },
+ method: 'POST',
+ success: function () {
+ let sv = view.query('pveHAStatusView')[0];
+ sv.isDisarmedPendingState = true;
+ sv.setPending(true);
+ },
+ failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus),
+ });
+ },
+ );
+ },
+
+ handleArmButton: function () {
+ let me = this;
+ let view = me.getView();
+
+ Ext.Msg.confirm(
+ gettext('Confirm'),
+ gettext('Are you sure you want to arm HA?'),
+ function (btn) {
+ if (btn !== 'yes') {
+ return;
+ }
+ Proxmox.Utils.API2Request({
+ url: '/cluster/ha/status/arm-ha',
+ method: 'POST',
+ success: function () {
+ let sv = view.query('pveHAStatusView')[0];
+ sv.isDisarmedPendingState = false;
+ sv.setPending(true);
+ },
+ failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus),
+ });
+ },
+ );
+ },
+ },
+
+ tbar: [
+ {
+ text: gettext('Arm HA'),
+ iconCls: 'fa fa-link',
+ bind: {
+ disabled: '{!haDisarmed}',
+ },
+ handler: 'handleArmButton',
+ },
+ {
+ text: gettext('Disarm HA'),
+ iconCls: 'fa fa-unlink',
+ bind: {
+ disabled: '{haDisarmed}',
+ },
+ menu: [
+ {
+ text: gettext('Freeze'),
+ details: gettext(
+ 'This will freeze all services allowing no change to their operational state.',
+ ),
+ iconCls: 'fa fa-snowflake-o',
+ mode: 'freeze',
+ handler: 'handleDisarmButton',
+ },
+ {
+ text: gettext('Ignore'),
+ details: gettext(
+ 'The HA stack will be completely bypassed when the operational state of a service changes.',
+ ),
+ iconCls: 'fa fa-eye-slash',
+ mode: 'ignore',
+ handler: 'handleDisarmButton',
+ },
+ ],
+ },
+ ],
+
initComponent: function () {
var me = this;
@@ -30,6 +138,23 @@ Ext.define('PVE.ha.Status', {
border: 0,
collapsible: true,
padding: '0 0 20 0',
+ listeners: {
+ hastatuschange: function (isDisarmed) {
+ let vm = me.getViewModel();
+ let sv = me.query('pveHAStatusView')[0];
+
+ vm.set('haDisarmed', isDisarmed);
+
+ if (sv.isDisarmedPendingState === null) {
+ return;
+ }
+
+ if (isDisarmed === sv.isDisarmedPendingState) {
+ sv.setPending(false);
+ sv.isDisarmedPendingState = null;
+ }
+ },
+ },
},
{
xtype: 'pveHAResourcesView',
diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js
index bc2da71f..33112c45 100644
--- a/www/manager6/ha/StatusView.js
+++ b/www/manager6/ha/StatusView.js
@@ -14,6 +14,15 @@ Ext.define(
service: 5,
},
+ pending: false,
+ isDisarmedPendingState: null,
+
+ setPending: function (pending) {
+ let me = this;
+ me.pending = pending;
+ me.getView().refresh();
+ },
+
initComponent: function () {
var me = this;
@@ -42,6 +51,13 @@ Ext.define(
},
});
+ me.rstore.on('load', function () {
+ let fencing = store.findRecord('type', 'fencing');
+ let disarmed = fencing && fencing.get('armed-state') === 'disarmed';
+
+ me.fireEvent('hastatuschange', disarmed);
+ });
+
Ext.apply(me, {
store: store,
stateful: false,
@@ -59,6 +75,12 @@ Ext.define(
width: 80,
flex: 1,
dataIndex: 'status',
+ renderer: function (value, _metaData, rec) {
+ if (rec.data.type === 'fencing' && me.pending) {
+ return value + ' <i class="fa fa-spinner fa-spin"></i>';
+ }
+ return value;
+ },
},
],
});
@@ -105,6 +127,7 @@ Ext.define(
return PVE.data.ResourceStore.guestName(vmid);
},
},
+ 'armed-state',
],
idProperty: 'id',
});
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* applied: [PATCH manager v5] ui: ha: add disarm/re-arm button
2026-05-13 14:12 [PATCH manager v5] ui: ha: add disarm/re-arm button Dominik Rusovac
@ 2026-05-15 5:04 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-05-15 5:04 UTC (permalink / raw)
To: pve-devel, Dominik Rusovac
On Wed, 13 May 2026 16:12:45 +0200, Dominik Rusovac wrote:
> The button to disarm HA in either of the resource modes ('freeze' or
> 'ignore') is disabled as long as HA is disarmed. Analogously, the button
> to arm HA is disabled as long as HA is not disarmed.
>
> For feedback, after clicking either of the buttons, icon spins as long as
> (dis)arming process has not changed the armed-state of HA.
>
> [...]
Applied, thanks!
[1/1] ui: ha: add disarm/re-arm button
commit: 8a88671fd85464dbb4ae6ff7aa63209185220e99
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-15 5:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-13 14:12 [PATCH manager v5] ui: ha: add disarm/re-arm button Dominik Rusovac
2026-05-15 5:04 ` applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox