From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 73F3A1FF13A for ; Wed, 13 May 2026 16:13:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5ED3E10BAA; Wed, 13 May 2026 16:13:25 +0200 (CEST) From: Dominik Rusovac To: pve-devel@lists.proxmox.com Subject: [PATCH manager v5] ui: ha: add disarm/re-arm button Date: Wed, 13 May 2026 16:12:45 +0200 Message-ID: <20260513141245.1208662-1-d.rusovac@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778681565702 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.332 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YFJYUVLYKIV74PAAQM6QRYWASBGW3I2J X-Message-ID-Hash: YFJYUVLYKIV74PAAQM6QRYWASBGW3I2J X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The button to disarm HA in either of the resource modes ('freeze' or 'ignore') is disabled as long as HA is disarmed. Analogously, the button to arm HA is disabled as long as HA is not disarmed. For feedback, after clicking either of the buttons, icon spins as long as (dis)arming process has not changed the armed-state of HA. The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA" and "Arm HA" are complements. There may be more suitable pairs of icons though. Signed-off-by: Dominik Rusovac --- Notes: changes since v4: * fix `gettext()` wrapping www/manager6/ha/Status.js | 125 ++++++++++++++++++++++++++++++++++ www/manager6/ha/StatusView.js | 23 +++++++ 2 files changed, 148 insertions(+) diff --git a/www/manager6/ha/Status.js b/www/manager6/ha/Status.js index b0b0feb9..26a6c901 100644 --- a/www/manager6/ha/Status.js +++ b/www/manager6/ha/Status.js @@ -8,6 +8,114 @@ Ext.define('PVE.ha.Status', { align: 'stretch', }, + viewModel: { + data: { + haDisarmed: false, + }, + }, + + controller: { + xclass: 'Ext.app.ViewController', + + handleDisarmButton: function (menuItem) { + let me = this; + let view = me.getView(); + + let warn = Ext.String.format( + gettext("Are you sure you want to disarm HA with resource mode '{0}'?"), + menuItem.text, + ); + + let details = gettext( + 'While disarmed, HA does not protect your services. Failures during this period are not automatically recovered.', + ); + + Ext.Msg.confirm( + gettext('Confirm'), + warn + '

' + menuItem.details + '

' + details, + function (btn) { + if (btn !== 'yes') { + return; + } + Proxmox.Utils.API2Request({ + url: '/cluster/ha/status/disarm-ha', + params: { 'resource-mode': menuItem.mode }, + method: 'POST', + success: function () { + let sv = view.query('pveHAStatusView')[0]; + sv.isDisarmedPendingState = true; + sv.setPending(true); + }, + failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus), + }); + }, + ); + }, + + handleArmButton: function () { + let me = this; + let view = me.getView(); + + Ext.Msg.confirm( + gettext('Confirm'), + gettext('Are you sure you want to arm HA?'), + function (btn) { + if (btn !== 'yes') { + return; + } + Proxmox.Utils.API2Request({ + url: '/cluster/ha/status/arm-ha', + method: 'POST', + success: function () { + let sv = view.query('pveHAStatusView')[0]; + sv.isDisarmedPendingState = false; + sv.setPending(true); + }, + failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus), + }); + }, + ); + }, + }, + + tbar: [ + { + text: gettext('Arm HA'), + iconCls: 'fa fa-link', + bind: { + disabled: '{!haDisarmed}', + }, + handler: 'handleArmButton', + }, + { + text: gettext('Disarm HA'), + iconCls: 'fa fa-unlink', + bind: { + disabled: '{haDisarmed}', + }, + menu: [ + { + text: gettext('Freeze'), + details: gettext( + 'This will freeze all services allowing no change to their operational state.', + ), + iconCls: 'fa fa-snowflake-o', + mode: 'freeze', + handler: 'handleDisarmButton', + }, + { + text: gettext('Ignore'), + details: gettext( + 'The HA stack will be completely bypassed when the operational state of a service changes.', + ), + iconCls: 'fa fa-eye-slash', + mode: 'ignore', + handler: 'handleDisarmButton', + }, + ], + }, + ], + initComponent: function () { var me = this; @@ -30,6 +138,23 @@ Ext.define('PVE.ha.Status', { border: 0, collapsible: true, padding: '0 0 20 0', + listeners: { + hastatuschange: function (isDisarmed) { + let vm = me.getViewModel(); + let sv = me.query('pveHAStatusView')[0]; + + vm.set('haDisarmed', isDisarmed); + + if (sv.isDisarmedPendingState === null) { + return; + } + + if (isDisarmed === sv.isDisarmedPendingState) { + sv.setPending(false); + sv.isDisarmedPendingState = null; + } + }, + }, }, { xtype: 'pveHAResourcesView', diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js index bc2da71f..33112c45 100644 --- a/www/manager6/ha/StatusView.js +++ b/www/manager6/ha/StatusView.js @@ -14,6 +14,15 @@ Ext.define( service: 5, }, + pending: false, + isDisarmedPendingState: null, + + setPending: function (pending) { + let me = this; + me.pending = pending; + me.getView().refresh(); + }, + initComponent: function () { var me = this; @@ -42,6 +51,13 @@ Ext.define( }, }); + me.rstore.on('load', function () { + let fencing = store.findRecord('type', 'fencing'); + let disarmed = fencing && fencing.get('armed-state') === 'disarmed'; + + me.fireEvent('hastatuschange', disarmed); + }); + Ext.apply(me, { store: store, stateful: false, @@ -59,6 +75,12 @@ Ext.define( width: 80, flex: 1, dataIndex: 'status', + renderer: function (value, _metaData, rec) { + if (rec.data.type === 'fencing' && me.pending) { + return value + ' '; + } + return value; + }, }, ], }); @@ -105,6 +127,7 @@ Ext.define( return PVE.data.ResourceStore.guestName(vmid); }, }, + 'armed-state', ], idProperty: 'id', }); -- 2.47.3